Skip to contentSkip to conversation

rockchip: ram: sdram_rk3x88: replace comma by semicolon

PATCH In review Johan Jonker 4 participants 4 messages Jan 12, 2022 – Mar 14, 2022 Arm Rockchip

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rockchip: ram: sdram_rk3x88: replace comma by semicolon

A comma at the end of a line gives sometimes strange effects in combination with some code formatters, so replace a comma by a semicolon in the sdram_rk3188.c and sdram_rk3288.c files.

---
 drivers/ram/rockchip/sdram_rk3188.c | 2 +-
 drivers/ram/rockchip/sdram_rk3288.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/ram/rockchip/sdram_rk3188.c +1 -1
index d9ed8adf..be8ba446 100644
@@ -762,7 +762,7 @@ static int sdram_init(struct dram_info *dram,
 		 * CS1, n=2
 		 * CS0 & CS1, n = 3
 		 */
-		sdram_params->ch[channel].rank = 2,
+		sdram_params->ch[channel].rank = 2;
 		clrsetbits_le32(&publ->pgcr, 0xF << 18,
 				(sdram_params->ch[channel].rank | 1) << 18);
 
drivers/ram/rockchip/sdram_rk3288.c +1 -1
index f3e4a280..227a3cc6 100644
@@ -862,7 +862,7 @@ static int sdram_init(struct dram_info *dram,
 		 * CS1, n=2
 		 * CS0 & CS1, n = 3
 		 */
-		sdram_params->ch[channel].rank = 2,
+		sdram_params->ch[channel].rank = 2;
 		clrsetbits_le32(&publ->pgcr, 0xF << 18,
 				(sdram_params->ch[channel].rank | 1) << 18);
 
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Johan Jonker

A comma at the end of a line gives sometimes strange effects in combination with some code formatters, so replace a comma by a semicolon in the sdram_rk3188.c and sdram_rk3288.c files.

Quoted 6 lines
---
 drivers/ram/rockchip/sdram_rk3188.c | 2 +-
 drivers/ram/rockchip/sdram_rk3288.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Reviewed-by on v1 1/1
#3 lore raw
In reply to Johan Jonker

Hi Johan,

Quoted 7 lines · Johan Jonker <[email protected]> 于2022年1月13日周四 00:32写道:

A comma at the end of a line gives sometimes strange effects in combination with some code formatters, so replace a comma by a semicolon in the sdram_rk3188.c and sdram_rk3288.c files.

Thanks,
- Kever

Quoted 34 lines
---
 drivers/ram/rockchip/sdram_rk3188.c | 2 +-
 drivers/ram/rockchip/sdram_rk3288.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/ram/rockchip/sdram_rk3188.c +1 -1
index d9ed8adf..be8ba446 100644
@@ -762,7 +762,7 @@ static int sdram_init(struct dram_info *dram,
                 * CS1, n=2
                 * CS0 & CS1, n = 3
                 */
-               sdram_params->ch[channel].rank = 2,
+               sdram_params->ch[channel].rank = 2;
                clrsetbits_le32(&publ->pgcr, 0xF << 18,
                                (sdram_params->ch[channel].rank | 1) << 18);
 
drivers/ram/rockchip/sdram_rk3288.c +1 -2
index f3e4a280..227a3cc6 100644
@@ -862,7 +862,7 @@ static int sdram_init(struct dram_info *dram,
                 * CS1, n=2
                 * CS0 & CS1, n = 3
                 */
-               sdram_params->ch[channel].rank = 2,
+               sdram_params->ch[channel].rank = 2;
                clrsetbits_le32(&publ->pgcr, 0xF << 18,
                                (sdram_params->ch[channel].rank | 1) << 18);
 
--

2.20.1