ocfs2: remove redundant assignment to variable free_space
Subsystems (2)
PATCH 1/1 ocfs2: remove redundant assignment to variable free_space
Variable free_space is being initialized with a value that is not read, it is being re-assigned later in the two paths of an if statement. The early initialization is redundant and can be removed.
Signed-off-by Colin Ian King <[email protected]>
--- fs/ocfs2/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ocfs2/dir.c +1 -1
@@ -3343,7 +3343,7 @@ static int ocfs2_find_dir_space_id(struct inode *dir, struct buffer_head *di_bh,struct ocfs2_dir_entry *de, *last_de =NULL ;char *de_buf, *limit;unsigned long offset =0 ; -unsigned int rec_len, new_rec_len, free_space = dir->i_sb->s_blocksize; +unsigned int rec_len, new_rec_len, free_space;/* * This calculates how many free bytes we'd have in block zero, should
Signature · 1 line
2.33.1
Quoted 5 lines · Colin Ian King
Variable
free_spaceis being initialized with a value that is not read, it is being re-assigned later in the two paths of an if statement. The early initialization is redundant and can be removed.Signed-off-by Colin Ian King <[email protected]>
Acked-by Joseph Qi <[email protected]>
Quoted 17 lines
--- fs/ocfs2/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)fs/ocfs2/dir.c +1
-1@@ -3343,7 +3343,7 @@ static int ocfs2_find_dir_space_id(struct inode *dir, struct buffer_head *di_bh,struct ocfs2_dir_entry *de, *last_de =NULL ;char *de_buf, *limit;unsigned long offset =0 ; -unsigned int rec_len, new_rec_len, free_space = dir->i_sb->s_blocksize; +unsigned int rec_len, new_rec_len, free_space;/* * This calculates how many free bytes we'd have in block zero, should