Skip to contentSkip to conversation

crypto: rsa-pkcs1pad - only allow with rsa

PATCH New Eric Biggers 1 participant 1 message Jan 13, 2022

Subsystems (4)
Stable branch Crypto API Keys/keyrings Asymmetric keys - rsa
lore
Share & tools
lore

Eric Biggers

author
#0 lore raw

PATCH 1/1 crypto: rsa-pkcs1pad - only allow with rsa

From: Eric Biggers <[email protected]>

The pkcs1pad template can be instantiated with an arbitrary akcipher algorithm, which doesn't make sense; it is specifically an RSA padding scheme. Make it check that the underlying algorithm really is RSA.

Fixes 3d5b1ecdea6f ("crypto: rsa - RSA padding algorithm")
Cc <[email protected]> # v4.5+
Signed-off-by Eric Biggers <[email protected]>
---
 crypto/rsa-pkcs1pad.c | 5 +++++
 1 file changed, 5 insertions(+)
crypto/rsa-pkcs1pad.c +5 -0
index 8ac3e73e8ea6..1b3545781425 100644
@@ -621,6 +621,11 @@ static int pkcs1pad_create(struct crypto_template *tmpl, struct rtattr **tb)
 
 	rsa_alg = crypto_spawn_akcipher_alg(&ctx->spawn);
 
+	if (strcmp(rsa_alg->base.cra_name, "rsa") != 0) {
+		err = -EINVAL;
+		goto err_free_inst;
+	}
+
 	err = -ENAMETOOLONG;
 	hash_name = crypto_attr_alg_name(tb[2]);
 	if (IS_ERR(hash_name)) {

base-commit: feb7a43de5ef625ad74097d8fd3481d5dbc06a59

Signature · 1 line
2.34.1