Skip to contentSkip to conversation

libtirpc: Fix use-after-free accessing the error number

PATCH In review Frank Sorenson 2 participants 2 messages Jan 13, 2022 – Jan 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libtirpc: Fix use-after-free accessing the error number

Free the cbuf after obtaining the error number.

---
 src/clnt_dg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/clnt_dg.c +1 -1
index e1255de..b3d82e7 100644
@@ -456,9 +456,9 @@ get_reply:
 		 cmsg = CMSG_NXTHDR (&msg, cmsg))
 	      if (cmsg->cmsg_level == SOL_IP && cmsg->cmsg_type == IP_RECVERR)
 		{
-		  mem_free(cbuf, (outlen + 256));
 		  e = (struct sock_extended_err *) CMSG_DATA(cmsg);
 		  cu->cu_error.re_errno = e->ee_errno;
+		  mem_free(cbuf, (outlen + 256));
 		  release_fd_lock(cu->cu_fd_lock, mask);
 		  return (cu->cu_error.re_status = RPC_CANTRECV);
 		}
Signature · 1 line
2.31.1
#1 lore raw
Quoted 3 lines · Frank Sorenson

Free the cbuf after obtaining the error number.

Committed (tag: libtirpc-1-3-3-rc2)

steved.

Quoted 19 lines
---
  src/clnt_dg.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
src/clnt_dg.c +1 -1
index e1255de..b3d82e7 100644
@@ -456,9 +456,9 @@ get_reply:
  		 cmsg = CMSG_NXTHDR (&msg, cmsg))
  	      if (cmsg->cmsg_level == SOL_IP && cmsg->cmsg_type == IP_RECVERR)
  		{
-		  mem_free(cbuf, (outlen + 256));
  		  e = (struct sock_extended_err *) CMSG_DATA(cmsg);
  		  cu->cu_error.re_errno = e->ee_errno;
+		  mem_free(cbuf, (outlen + 256));
  		  release_fd_lock(cu->cu_fd_lock, mask);
  		  return (cu->cu_error.re_status = RPC_CANTRECV);
  		}