Skip to contentSkip to conversation

package/kf5/kf5-extra-cmake-modules: do not build documentation

PATCH Applied Adrian Perez de Castro 3 participants 3 messages Jan 13, 2022 – Feb 16, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kf5/kf5-extra-cmake-modules: do not build documentation

Pass needed CMake options to disable generating documentations. The documentation is built using python-sphinx, which is not packaged in Buildroot.

Prior to this change, if the build host would have a Python installation with the sphinx module installed the automatic detection tried to build documentation, which would fail in cases where the sphinxcontrib-qthelp package is missing from the host Python installation. The error message in this case was:

Extension error:
Could not import extension ecm (exception: cannot import name
'htmlescape' from 'sphinx.util.pycompat' (/usr/lib/python3.10/site-packages/sphinx/util/pycompat.py))

---
 .../kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk   | 5 +++++
 1 file changed, 5 insertions(+)
package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk +5 -0
index 3c4281b960..ba2748456e 100644
@@ -14,4 +14,9 @@ KF5_EXTRA_CMAKE_MODULES_DEPENDENCIES = host-pkgconf
 KF5_EXTRA_CMAKE_MODULES_INSTALL_STAGING = YES
 KF5_EXTRA_CMAKE_MODULES_INSTALL_TARGET = NO
 
+KF5_EXTRA_CMAKE_MODULES_CONF_OPTS += \
+	-DBUILD_HTML_DOCS=OFF \
+	-DBUILD_MAN_DOCS=OFF \
+	-DBUILD_QTHELP_DOCS=OFF
+
 $(eval $(cmake-package))
Signature · 6 lines
2.34.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 10 lines · Adrian Perez de Castro

Pass needed CMake options to disable generating documentations. The documentation is built using python-sphinx, which is not packaged in Buildroot.

Prior to this change, if the build host would have a Python installation with the sphinx module installed the automatic detection tried to build documentation, which would fail in cases where the sphinxcontrib-qthelp package is missing from the host Python installation. The error message in this case was:

Quoted 6 lines

Extension error:
Could not import extension ecm (exception: cannot import name
'htmlescape' from 'sphinx.util.pycompat' (/usr/lib/python3.10/site-packages/sphinx/util/pycompat.py))

Applied to master, thanks.

(AFAICS the v2 was in fact identical)

Regards,
Arnout

Quoted 9 lines
---
  .../kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk   | 5 +++++
  1 file changed, 5 insertions(+)
package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk +0 -0
index 3c4281b960..ba2748456e 100644

package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk KF5_EXTRA_CMAKE_MODULES_DEPENDENCIES = host-pkgconf · line 22

Quoted 9 lines
package/kf5/kf5-extra-cmake-modules/kf5-extra-cmake-modules.mk +5 -0
@@ -14,4 +14,9 @@ KF5_EXTRA_CMAKE_MODULES_DEPENDENCIES = host-pkgconf
  KF5_EXTRA_CMAKE_MODULES_INSTALL_STAGING = YES
  KF5_EXTRA_CMAKE_MODULES_INSTALL_TARGET = NO
 
+KF5_EXTRA_CMAKE_MODULES_CONF_OPTS += \
+	-DBUILD_HTML_DOCS=OFF \
+	-DBUILD_MAN_DOCS=OFF \
+	-DBUILD_QTHELP_DOCS=OFF
+
  $(eval $(cmake-package))

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
Quoted 18 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Quoted 15 lines · Adrian Perez de Castro

Pass needed CMake options to disable generating documentations. The documentation is built using python-sphinx, which is not packaged in Buildroot.

Prior to this change, if the build host would have a Python installation with the sphinx module installed the automatic detection tried to build documentation, which would fail in cases where the sphinxcontrib-qthelp package is missing from the host Python installation. The error message in this case was:

Extension error:
Could not import extension ecm (exception: cannot import name 'htmlescape' from 'sphinx.util.pycompat' (/usr/lib/python3.10/site-packages/sphinx/util/pycompat.py))

Quoted 5 lines
Quoted 1 line

Applied to master, thanks.

(AFAICS the v2 was in fact identical)

Committed to 2021.02.x and 2021.11.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot