Skip to contentSkip to conversation

Reserve more feature bits for device type usage

PATCH In review Cornelia Huck 2 participants 7 messages Jan 14, 2022 – Feb 2, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Reserve more feature bits for device type usage

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
 content.tex | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
 Feature bits are allocated as follows:
 
 \begin{description}
-\item[0 to 23] Feature bits for the specific device type
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
 \item[24 to 40] Feature bits reserved for extensions to the queue and
   feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
 \end{description}
 
 \begin{note}
Signature · 1 line
2.31.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 29 lines · Cornelia Huck

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -1
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  Feature bits are allocated as follows:
 
  \begin{description}
-\item[0 to 23] Feature bits for the specific device type

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 10 lines
content.tex +2 -1
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
  \item[24 to 40] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
  \end{description}
 
  \begin{note}

Looks reasonable to me.

#2 lore raw
In reply to Cornelia Huck
Quoted 29 lines · Cornelia Huck

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +0 -1
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  Feature bits are allocated as follows:
 
  \begin{description}
-\item[0 to 23] Feature bits for the specific device type

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 10 lines
content.tex +2 -1
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
  \item[24 to 40] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
  \end{description}
 
  \begin{note}

Cornelia,

I've noticed that Legacy net device has VIRTIO_NET_F_GUEST_RSC4 (41) and VIRTIO_NET_F_GUEST_RSC6 (42).

Do we need to reserved them too or keep the fix as-is ?

#3 lore raw
Quoted 39 lines · Max Gurtovoy
Quoted 38 lines · Cornelia Huck

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
  content.tex | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
  Feature bits are allocated as follows:
 
  \begin{description}
-\item[0 to 23] Feature bits for the specific device type
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
  \item[24 to 40] Feature bits reserved for extensions to the queue and
    feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
  \end{description}
 
Quoted 8 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 1 line
content.tex +0 -0
  \begin{note}

Cornelia,

I've noticed that Legacy net device has VIRTIO_NET_F_GUEST_RSC4 (41) and VIRTIO_NET_F_GUEST_RSC6 (42).

Do we need to reserved them too or keep the fix as-is ?

Eww. I think those bits shouldn't have been hiding in the "legacy" section, as their higher number indicates that they are not for a legacy device in the spec sense.

They have been introduced in
https://github.com/oasis-tcs/virtio-spec/issues/21 in 2018, I'm wondering how old those Windows drivers referred to in there are. IOW, would a new feature bit 41/42 break things for currently used Windows drivers if it showed up on a virtio-net device? If we still care about those drivers, we should reserve bits 41 and 42 as do-not-use, I guess.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

#4 lore raw
Quoted 52 lines · Cornelia Huck
Quoted 39 lines · Max Gurtovoy
Quoted 38 lines · Cornelia Huck

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
   content.tex | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
   Feature bits are allocated as follows:
 
   \begin{description}
-\item[0 to 23] Feature bits for the specific device type
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
   \item[24 to 40] Feature bits reserved for extensions to the queue and
     feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
   \end{description}
 
Quoted 7 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 1 line
content.tex +0 -0
   \begin{note}

Cornelia,

I've noticed that Legacy net device has VIRTIO_NET_F_GUEST_RSC4 (41) and VIRTIO_NET_F_GUEST_RSC6 (42).

Do we need to reserved them too or keep the fix as-is ?

Eww. I think those bits shouldn't have been hiding in the "legacy" section, as their higher number indicates that they are not for a legacy device in the spec sense.

Quoted 6 lines

They have been introduced in
https://github.com/oasis-tcs/virtio-spec/issues/21 in 2018, I'm wondering how old those Windows drivers referred to in there are. IOW, would a new feature bit 41/42 break things for currently used Windows drivers if it showed up on a virtio-net device? If we still care about those drivers, we should reserve bits 41 and 42 as do-not-use, I guess.

I've not idea about the windows drivers.

But the bit 41 is currently the bit I use to negotiate the AQ in the last patchset so we need to decide how to progress.

Thanks.

#5 lore raw
Quoted 60 lines · Max Gurtovoy
Quoted 52 lines · Cornelia Huck
Quoted 39 lines · Max Gurtovoy
Quoted 38 lines · Cornelia Huck

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
   content.tex | 4 ++--
   1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
   Feature bits are allocated as follows:
 
   \begin{description}
-\item[0 to 23] Feature bits for the specific device type
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
   \item[24 to 40] Feature bits reserved for extensions to the queue and
     feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
   \end{description}
 
Quoted 7 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 1 line
content.tex +0 -0
   \begin{note}

Cornelia,

I've noticed that Legacy net device has VIRTIO_NET_F_GUEST_RSC4 (41) and VIRTIO_NET_F_GUEST_RSC6 (42).

Do we need to reserved them too or keep the fix as-is ?

Eww. I think those bits shouldn't have been hiding in the "legacy" section, as their higher number indicates that they are not for a legacy device in the spec sense.

Quoted 6 lines

They have been introduced in
https://github.com/oasis-tcs/virtio-spec/issues/21 in 2018, I'm wondering how old those Windows drivers referred to in there are. IOW, would a new feature bit 41/42 break things for currently used Windows drivers if it showed up on a virtio-net device? If we still care about those drivers, we should reserve bits 41 and 42 as do-not-use, I guess.

Quoted 4 lines

I've not idea about the windows drivers.

But the bit 41 is currently the bit I use to negotiate the AQ in the last patchset so we need to decide how to progress.

For your purpose, it would probably be best to simply go with 43 in your next update.

We have to come to a conclusion before we merge any new feature using a bit in that range anyway... and I really would like to have that cleared up before we do our draft :/

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#6 lore raw
Quoted 61 lines · Cornelia Huck
Quoted 59 lines · Max Gurtovoy
Quoted 58 lines · Cornelia Huck
Quoted 39 lines · Max Gurtovoy
Quoted 38 lines · Cornelia Huck

Feature bits 41 and above are noted as being reserved for future extensions. However, the net device has been using bits in that space for some time now, as it already used up the device type specific range up to 23.

To avoid problems in the future, let's designate bits 50 to 127 to device type specific usage (which accommodates current usage by the net driver, and gives breathing room for future type specific bits), and declare bits 41 to 49 and bits 128 and above to be reserved for future extensions (which gives us some time before bit numbers move beyond 63, which would need some changes in existing device and driver implementations.)

---
    content.tex | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)
content.tex +2 -2
index 32de6685c50b..c6f116c7aa39 100644
@@ -97,12 +97,12 @@ \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B
    Feature bits are allocated as follows:
 
    \begin{description}
-\item[0 to 23] Feature bits for the specific device type
+\item[0 to 23, and 50 to 127] Feature bits for the specific device type
 
    \item[24 to 40] Feature bits reserved for extensions to the queue and
      feature negotiation mechanisms
 
-\item[41 and above] Feature bits reserved for future extensions.
+\item[41 to 49, and 128 and above] Feature bits reserved for future extensions.
    \end{description}
 
Quoted 7 lines

content.tex \section{Feature Bits}\label{sec:Basic Facilities of a Virtio Device / Feature B · line 108

Quoted 1 line
content.tex +0 -0
    \begin{note}

Cornelia,

I've noticed that Legacy net device has VIRTIO_NET_F_GUEST_RSC4 (41) and VIRTIO_NET_F_GUEST_RSC6 (42).

Do we need to reserved them too or keep the fix as-is ?

Eww. I think those bits shouldn't have been hiding in the "legacy" section, as their higher number indicates that they are not for a legacy device in the spec sense.

They have been introduced in
https://github.com/oasis-tcs/virtio-spec/issues/21 in 2018, I'm wondering how old those Windows drivers referred to in there are. IOW, would a new feature bit 41/42 break things for currently used Windows drivers if it showed up on a virtio-net device? If we still care about those drivers, we should reserve bits 41 and 42 as do-not-use, I guess.

Quoted 6 lines
Quoted 4 lines

I've not idea about the windows drivers.

But the bit 41 is currently the bit I use to negotiate the AQ in the last patchset so we need to decide how to progress.

For your purpose, it would probably be best to simply go with 43 in your next update.

it won't align with the Feature bits section so I'll keep it 41 for v3 and hope it will be resolved by v4...

Quoted 5 lines

We have to come to a conclusion before we merge any new feature using a bit in that range anyway... and I really would like to have that cleared up before we do our draft :/