Skip to contentSkip to conversation

net/memif: remove unnecessary rx_intr stub

PATCH Applied Stephen Hemminger 3 participants 3 messages Jan 14, 2022 – Jan 26, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/memif: remove unnecessary rx_intr stub

The code in memif driver to stub out rx_irq_enable is unnecessary and causes different error returns than other drivers. The core ethdev code will return -ENOTSUP if the driver has a null rx_queue_intr_enable callback.

Fixes 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
---
 drivers/net/memif/rte_eth_memif.c | 19 -------------------
 1 file changed, 19 deletions(-)
drivers/net/memif/rte_eth_memif.c +0 -19
index 59cb5a82a23f..d3459c5007c4 100644
@@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev)
 	return 0;
 }
 
-static int
-memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused,
-			   uint16_t qid __rte_unused)
-{
-	MIF_LOG(WARNING, "Interrupt mode not supported.");
-
-	return -1;
-}
-
-static int
-memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid __rte_unused)
-{
-	struct pmd_internals *pmd __rte_unused = dev->data->dev_private;
-
-	return 0;
-}
-
 static const struct eth_dev_ops ops = {
 	.dev_start = memif_dev_start,
 	.dev_stop = memif_dev_stop,
@@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = {
 	.rx_queue_setup = memif_rx_queue_setup,
 	.rx_queue_release = memif_rx_queue_release,
 	.tx_queue_release = memif_tx_queue_release,
-	.rx_queue_intr_enable = memif_rx_queue_intr_enable,
-	.rx_queue_intr_disable = memif_rx_queue_intr_disable,
 	.link_update = memif_link_update,
 	.stats_get = memif_stats_get,
 	.stats_reset = memif_stats_reset,
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 55 lines

From: Stephen Hemminger [mailto:[email protected]]
Sent: Friday, 14 January 2022 21.47

The code in memif driver to stub out rx_irq_enable is unnecessary and causes different error returns than other drivers. The core ethdev code will return -ENOTSUP if the driver has a null rx_queue_intr_enable callback.

Fixes 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
---
 drivers/net/memif/rte_eth_memif.c | 19 -------------------
 1 file changed, 19 deletions(-)
drivers/net/memif/rte_eth_memif.c +0 -17
index 59cb5a82a23f..d3459c5007c4 100644
@@ -1500,23 +1500,6 @@ memif_stats_reset(struct rte_eth_dev *dev)
 	return 0;
 }
 
-static int
-memif_rx_queue_intr_enable(struct rte_eth_dev *dev __rte_unused,
-			   uint16_t qid __rte_unused)
-{
-	MIF_LOG(WARNING, "Interrupt mode not supported.");
-
-	return -1;
-}
-
-static int
-memif_rx_queue_intr_disable(struct rte_eth_dev *dev, uint16_t qid
 __rte_unused)
-{
-	struct pmd_internals *pmd __rte_unused = dev->data->dev_private;
-
-	return 0;
-}
-
 static const struct eth_dev_ops ops = {
 	.dev_start = memif_dev_start,
drivers/net/memif/rte_eth_memif.c +0 -3
 	.dev_stop = memif_dev_stop,
@@ -1527,8 +1510,6 @@ static const struct eth_dev_ops ops = {
 	.rx_queue_setup = memif_rx_queue_setup,
 	.rx_queue_release = memif_rx_queue_release,
 	.tx_queue_release = memif_tx_queue_release,
-	.rx_queue_intr_enable = memif_rx_queue_intr_enable,
-	.rx_queue_intr_disable = memif_rx_queue_intr_disable,
 	.link_update = memif_link_update,
 	.stats_get = memif_stats_get,
 	.stats_reset = memif_stats_reset,
--
Quoted 2 lines

2.30.2

Reviewed-by Applied
#2 lore raw
Quoted 8 lines · Morten Brørup
Quoted 8 lines

From: Stephen Hemminger [mailto:[email protected]]
Sent: Friday, 14 January 2022 21.47

The code in memif driver to stub out rx_irq_enable is unnecessary and causes different error returns than other drivers. The core ethdev code will return -ENOTSUP if the driver has a null rx_queue_intr_enable callback.

Quoted 6 lines
Quoted 3 lines
Fixes 09c7e63a71f9 ("net/memif: introduce memory interface PMD")

No comment from maintainers, hence progressing,

Applied to dpdk-next-net/main, thanks.