http: parse HTTP headers case-insensitive
PATCH 1/1 http: parse HTTP headers case-insensitive
According to https://www.ietf.org/rfc/rfc2616.txt 4.2, header names shall be case insensitive and we are now forced to read headers like Content-Length capitalized.
The problem with that is when a HTTP server responds with a content-length header in lowercase GRUB gets stuck because HTTP module doesn't know the length of the transmision and the call never ends.
--- grub-core/net/http.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
grub-core/net/http.c +3 -3
@@ -130,7 +130,7 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) data->first_line_recv =1 ;return GRUB_ERR_NONE ; } -if (grub_memcmp (ptr,"Content-Length: " ,sizeof ("Content-Length: " ) -1 ) +if (grub_strncasecmp (ptr,"Content-Length: " ,sizeof ("Content-Length: " ) -1 ) ==0 && !data->size_recv) { ptr +=sizeof ("Content-Length: " ) -1 ;
@@ -138,8 +138,8 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) data->size_recv =1 ;return GRUB_ERR_NONE ; } -if (grub_memcmp (ptr,"Transfer-Encoding: chunked" , -sizeof ("Transfer-Encoding: chunked" ) -1 ) ==0 ) +if (grub_strncasecmp (ptr,"Transfer-Encoding: chunked" , +sizeof ("Transfer-Encoding: chunked" ) -1 ) ==0 ) { data->chunked =1 ;return GRUB_ERR_NONE ;
Signature · 1 line
2.32.0
Quoted 3 lines · On Fri, 14 Jan 2022 22:20:17 +0100 Jamo <[email protected]> wrote:
According to https://www.ietf.org/rfc/rfc2616.txt 4.2, header names shall be case insensitive and we are now forced to read headers like
Content-Lengthcapitalized.
I'm not sure if Daniel likes these backticks, perhaps normal quotes would be better. I'll let him chime in if so.
Quoted 3 lines
The problem with that is when a HTTP server responds with a
content-lengthheader in lowercase GRUB gets stuck because HTTP
There should be a ',' right after "lowercase".
Quoted 1 line
module doesn't know the length of the transmision and the call never
Just noticed that "transmision" should be spelled "transmission".
Quoted 19 lines
ends.
--- grub-core/net/http.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)grub-core/net/http.c +1
-1@@ -130,7 +130,7 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) data->first_line_recv =1 ;return GRUB_ERR_NONE ; } -if (grub_memcmp (ptr,"Content-Length: " ,sizeof ("Content-Length: " ) -1 ) +if (grub_strncasecmp (ptr,"Content-Length: " ,sizeof ("Content-Length: " ) -1 ) ==0 && !data->size_recv) { ptr +=sizeof ("Content-Length: " ) -1 ;
grub-core/net/http.c parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) · line 145
Quoted 10 lines
grub-core/net/http.c +2
-2@@ -138,8 +138,8 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, grub_size_t len) data->size_recv =1 ;return GRUB_ERR_NONE ; } -if (grub_memcmp (ptr,"Transfer-Encoding: chunked" , -sizeof ("Transfer-Encoding: chunked" ) -1 ) ==0 ) +if (grub_strncasecmp (ptr,"Transfer-Encoding: chunked" , +sizeof ("Transfer-Encoding: chunked" ) -1 ) ==0 ) { data->chunked =1 ;return GRUB_ERR_NONE ;
Aside from the minor stuff in the commit message, the patch looks good to me.
Glenn