Skip to contentSkip to conversation

platform/surface: Reinstate platform dependency

PATCH In review Geert Uytterhoeven 3 participants 3 messages Jan 15, 2022 – Jan 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 platform/surface: Reinstate platform dependency

Microsoft Surface platform-specific devices are only present on Microsoft Surface platforms, which are currently limited to arm64 and x86. Hence add a dependency on ARM64 || X86, to prevent asking the user about drivers for these devices when configuring a kernel for an architecture that does not support Microsoft Surface platforms.

Fixes 272479928172edf0 ("platform: surface: Propagate ACPI Dependency")
---
 drivers/platform/surface/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/surface/Kconfig +1 -0
index 5f0578e25f718f14..463f1ec5c14e9fa9 100644
@@ -5,6 +5,7 @@
 
 menuconfig SURFACE_PLATFORMS
 	bool "Microsoft Surface Platform-Specific Device Drivers"
+	depends on ARM64 || X86 || COMPILE_TEST
 	default y
 	help
 	  Say Y here to get to see options for platform-specific device drivers
Signature · 1 line
2.25.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Geert Uytterhoeven

Microsoft Surface platform-specific devices are only present on Microsoft Surface platforms, which are currently limited to arm64 and x86. Hence add a dependency on ARM64 || X86, to prevent asking the user about drivers for these devices when configuring a kernel for an architecture that does not support Microsoft Surface platforms.

Fixes 272479928172edf0 ("platform: surface: Propagate ACPI Dependency")

Seems sensible to me.

Quoted 16 lines
---
  drivers/platform/surface/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/platform/surface/Kconfig +1 -0
index 5f0578e25f718f14..463f1ec5c14e9fa9 100644
@@ -5,6 +5,7 @@
 
  menuconfig SURFACE_PLATFORMS
  	bool "Microsoft Surface Platform-Specific Device Drivers"
+	depends on ARM64 || X86 || COMPILE_TEST
  	default y
  	help
  	  Say Y here to get to see options for platform-specific device drivers
#2 lore raw
In reply to Geert Uytterhoeven

Hi,

Quoted 8 lines · Geert Uytterhoeven

Microsoft Surface platform-specific devices are only present on Microsoft Surface platforms, which are currently limited to arm64 and x86. Hence add a dependency on ARM64 || X86, to prevent asking the user about drivers for these devices when configuring a kernel for an architecture that does not support Microsoft Surface platforms.

Fixes 272479928172edf0 ("platform: surface: Propagate ACPI Dependency")

Thank you for your patch, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.

Regards,

Hans

Quoted 17 lines
---
 drivers/platform/surface/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/platform/surface/Kconfig +1 -0
index 5f0578e25f718f14..463f1ec5c14e9fa9 100644
@@ -5,6 +5,7 @@
 
 menuconfig SURFACE_PLATFORMS
 	bool "Microsoft Surface Platform-Specific Device Drivers"
+	depends on ARM64 || X86 || COMPILE_TEST
 	default y
 	help
 	  Say Y here to get to see options for platform-specific device drivers