Skip to contentSkip to conversation

mpage: remove ineffective __GFP_HIGH flag

PATCH In review Shakeel Butt 2 participants 3 messages Jan 15, 2022 – Jan 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpage: remove ineffective __GFP_HIGH flag

Since the commit 8a5c743e308dd ("mm, memcg: use consistent gfp flags during readahead") mpage_alloc is clearing all the flag bits other than bits in GFP_KERNEL internally. Simply remove __GFP_HIGH from the call to mpage_alloc as it is cleared by it.

---
 fs/mpage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/mpage.c +1 -1
index 87f5cfef6caa..477ccc3f3ac3 100644
@@ -609,7 +609,7 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
 				goto out;
 		}
 		bio = mpage_alloc(bdev, blocks[0] << (blkbits - 9),
-				BIO_MAX_VECS, GFP_NOFS|__GFP_HIGH);
+				  BIO_MAX_VECS, GFP_NOFS);
 		if (bio == NULL)
 			goto confused;
 
Signature · 1 line
2.34.1.703.g22d0c6ccf7-goog
#1 lore raw

FYI, I have a patch removing mpage_alloc entirely as part of a bio allocation refactoring series about to be sent out. So while your analysis here is correct I'd prefer to hold this as the issue goes away entirely.

#2 lore raw
Quoted 5 lines · Christoph Hellwig

FYI, I have a patch removing mpage_alloc entirely as part of a bio allocation refactoring series about to be sent out. So while your analysis here is correct I'd prefer to hold this as the issue goes away entirely.

SGTM