Skip to contentSkip to conversation

ALSA: core: Fix SSID quirk lookup for subvendor=0

PATCH New Takashi Iwai 1 participant 1 message Jan 16, 2022 Sound

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ALSA: core: Fix SSID quirk lookup for subvendor=0

Some weird devices set the codec SSID vendor ID 0, and snd_pci_quirk_lookup_id() loop aborts at the point although it should still try matching with the SSID device ID. This resulted in a missing quirk for some old Macs.

Fix the loop termination condition to check both subvendor and subdevice.

Fixes 73355ddd8775 ("ALSA: hda: Code refactoring snd_hda_pick_fixup()")

---
v1->v2: Fix a typo of logical OR in the condition

 sound/core/misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/core/misc.c +1 -1
index 3579dd7a161f..50e4aaa6270d 100644
@@ -112,7 +112,7 @@ snd_pci_quirk_lookup_id(u16 vendor, u16 device,
 {
 	const struct snd_pci_quirk *q;
 
-	for (q = list; q->subvendor; q++) {
+	for (q = list; q->subvendor || q->subdevice; q++) {
 		if (q->subvendor != vendor)
 			continue;
 		if (!q->subdevice ||
Signature · 1 line
2.31.1