Skip to contentSkip to conversation

tcmode-default.inc: clear PREFERRED_VERSION for llvm

PATCH In review [email protected] 2 participants 3 messages Jan 16, 2022 – Jan 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tcmode-default.inc: clear PREFERRED_VERSION for llvm

From: Kai Kang <[email protected]>

When include layer meta-clang which set LLVMVERSION in layer.conf, it shows warnings:

| WARNING: preferred version 13.0.1 of llvm-native not available (for item llvm-native)
| WARNING: versions of llvm-native available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-dev)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-bugpointpasses)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-liboptremarks)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-llvmhello)
| WARNING: versions of llvm available: 12.0.1

Because only one version llvm exists, remove the PREFERRED_VERSION setting for llvm.

---
 meta/conf/distro/include/tcmode-default.inc | 4 ----
 1 file changed, 4 deletions(-)
meta/conf/distro/include/tcmode-default.inc +0 -4
index 49e99af8f2..2622b055a2 100644
@@ -79,10 +79,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
 
-PREFERRED_VERSION_llvm = "${LLVMVERSION}"
-PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
-PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
-
 # Rust toolchain preferred versions:
 
 PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 23 lines · On Sun, Jan 16, 2022 at 8:47 AM <[email protected]> wrote:

From: Kai Kang <[email protected]>

When include layer meta-clang which set LLVMVERSION in layer.conf, it shows warnings:

| WARNING: preferred version 13.0.1 of llvm-native not available (for item llvm-native)

| WARNING: versions of llvm-native available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item

llvm-dev)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-bugpointpasses)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-liboptremarks)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-llvmhello)
| WARNING: versions of llvm available: 12.0.1

Quoted 2 lines

Because only one version llvm exists, remove the PREFERRED_VERSION setting for llvm.

I think these are PROVIDERS mismatch more than anything between two recipes so perhaps it’s better to keep that in sync

Fwiw llvm is not heavily used in oe-core perhaps it should be removed

Quoted 27 lines
---
 meta/conf/distro/include/tcmode-default.inc | 4 ----
 1 file changed, 4 deletions(-)
meta/conf/distro/include/tcmode-default.inc +0 -5
index 49e99af8f2..2622b055a2 100644
@@ -79,10 +79,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
 PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"
 
-PREFERRED_VERSION_llvm = "${LLVMVERSION}"
-PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
-PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
-
 # Rust toolchain preferred versions:
 
 PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
--

2.17.1

author
#2 lore raw
Quoted 29 lines · Khem Raj

On Sun, Jan 16, 2022 at 8:47 AM <[email protected] <mailto:[email protected]>> wrote:

From: Kai Kang <[email protected]
<mailto:[email protected]>>

When include layer meta-clang which set LLVMVERSION in layer.conf, it shows warnings:

| WARNING: preferred version 13.0.1 of llvm-native not available (for item llvm-native)
| WARNING: versions of llvm-native available: 12.0.1 | WARNING: preferred version 13.0.1 of llvm not available (for item llvm)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-dev)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-bugpointpasses)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-liboptremarks)
| WARNING: versions of llvm available: 12.0.1
| WARNING: preferred version 13.0.1 of llvm not available (for item llvm-llvmhello)
| WARNING: versions of llvm available: 12.0.1

Quoted 5 lines

Because only one version llvm exists, remove the PREFERRED_VERSION setting for llvm.

I think these are PROVIDERS mismatch more than anything between two recipes so perhaps it’s better to keep that in sync

My doubt is that it seems only a single llvm recipe exists in oe-core around all the layers including meta-clang.

Regards,
Kai

Quoted 30 lines

Fwiw llvm is not heavily used in oe-core perhaps it should be removed

    Signed-off-by: Kai Kang <[email protected]
    <mailto:[email protected]>>
    ---
     meta/conf/distro/include/tcmode-default.inc | 4 ----
     1 file changed, 4 deletions(-)

    diff --git a/meta/conf/distro/include/tcmode-default.inc
    b/meta/conf/distro/include/tcmode-default.inc
    index 49e99af8f2..2622b055a2 100644
    --- a/meta/conf/distro/include/tcmode-default.inc
    +++ b/meta/conf/distro/include/tcmode-default.inc
    @@ -79,10 +79,6 @@ PREFERRED_VERSION_go-runtime ?= "${GOVERSION}"
     PREFERRED_VERSION_nativesdk-go ?= "${GOVERSION}"
     PREFERRED_VERSION_nativesdk-go-runtime ?= "${GOVERSION}"

    -PREFERRED_VERSION_llvm = "${LLVMVERSION}"
    -PREFERRED_VERSION_llvm-native = "${LLVMVERSION}"
    -PREFERRED_VERSION_nativesdk-llvm = "${LLVMVERSION}"
    -
     # Rust toolchain preferred versions:

     PREFERRED_VERSION_cargo ?= "${RUSTVERSION}"
    -- 
    2.17.1
Signature · 2 lines
Kai Kang
Wind River Linux