Skip to contentSkip to conversation

drivers/acpi/apei/erst: remove unneeded rc variable

PATCH In review [email protected] 2 participants 2 messages Jan 18, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/acpi/apei/erst: remove unneeded rc variable

From: Minghao Chi <[email protected]>

Return value from erst_get_record_id_begin() directly instead of taking this in another redundant variable.

---
 drivers/acpi/apei/erst.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/acpi/apei/erst.c +1 -5
index 242f3c2d5533..d9cf07b2a90b 100644
@@ -952,14 +952,10 @@ static int reader_pos;
 
 static int erst_open_pstore(struct pstore_info *psi)
 {
-	int rc;
-
 	if (erst_disable)
 		return -ENODEV;
 
-	rc = erst_get_record_id_begin(&reader_pos);
-
-	return rc;
+	return erst_get_record_id_begin(&reader_pos);
 }
 
 static int erst_close_pstore(struct pstore_info *psi)
Signature · 1 line
2.25.1
#1 lore raw
Quoted 8 lines · On Tue, Jan 18, 2022 at 07:53:49AM +0000, [email protected] wrote:

From: Minghao Chi <[email protected]>

Return value from erst_get_record_id_begin() directly instead of taking this in another redundant variable.

"Well, this doesn't look like an e-mail address of a physical person which is required for S-o-b tags."

https://lore.kernel.org/r/CAJZ5v0iipOm6DX3Fd8iNKF_LC6kJWCy=1LxFsh47z01UYDrRow@mail.gmail.com

Are you people actually reading email feedback or you're automatically dumping this crap to recipients without even looking?

Because if so, we can automatically send all that crap to /dev/null and the only thing that's going to be wasted is the energy used to send crap mails back'n'forth...

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette