drm/edid: Add Vive Pro 2 to non-desktop list
Subsystems (2)
PATCH 1/1 drm/edid: Add Vive Pro 2 to non-desktop list
--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/drm_edid.c +2 -1
@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('V' ,'L' ,'V' ,0x91bf ,EDID_QUIRK_NON_DESKTOP ), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), +EDID_QUIRK ('H' ,'V' ,'R' ,0xaa04 ,EDID_QUIRK_NON_DESKTOP ),/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),
base-commit: 99613159ad749543621da8238acf1a122880144e
Signature · 1 line
2.34.1
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 10 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0
drivers/gpu/drm/drm_edid.c static const struct edid_quirk { · line 203
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */
Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 8 lines
drivers/gpu/drm/drm_edid.c +1
-0EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), +EDID_QUIRK ('H' ,'V' ,'R' ,0xaa04 ,EDID_QUIRK_NON_DESKTOP ),/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),base-commit:
99613159ad749543621da8238acf1a122880144e
Please send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Signature · 2 lines
Best regards, Dmitry
Quoted 31 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 10 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0drivers/gpu/drm/drm_edid.c static const struct edid_quirk { · line 203
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 4 lines
drivers/gpu/drm/drm_edid.c +1
-0EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), + EDID_QUIRK('H', 'V', 'R', 0xaa04, EDID_QUIRK_NON_DESKTOP),
Quoted 7 lines
Quoted 4 lines
drivers/gpu/drm/drm_edid.c +0
-0/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See 2869f599c0d8 ("drm/edid: support Microsoft extension for HMDs and specialized monitors").
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 35 lines · Jani Nikula
Quoted 34 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 10 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0drivers/gpu/drm/drm_edid.c static const struct edid_quirk { · line 203
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 7 lines
drivers/gpu/drm/drm_edid.c +1
-0EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), +EDID_QUIRK ('H' ,'V' ,'R' ,0xaa04 ,EDID_QUIRK_NON_DESKTOP ),/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See
2869f599c0d8("drm/edid: support Microsoft extension for HMDs and specialized monitors").
Do you mean to skip using the EDID_QUIRK_NON_DESKTOP if MS VSDB entry presents in the EDID?
These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed.
Signature · 2 lines
Best regards, Dmitry
Quoted 41 lines · Dmitry Osipenko
Quoted 40 lines · Jani Nikula
Quoted 38 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 10 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0drivers/gpu/drm/drm_edid.c static const struct edid_quirk { · line 203
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 8 lines
drivers/gpu/drm/drm_edid.c +1
-0EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), +EDID_QUIRK ('H' ,'V' ,'R' ,0xaa04 ,EDID_QUIRK_NON_DESKTOP ),/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Quoted 8 lines
Quoted 3 lines
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See
2869f599c0d8("drm/edid: support Microsoft extension for HMDs and specialized monitors").Do you mean to skip using the
EDID_QUIRK_NON_DESKTOPif MS VSDB entry presents in the EDID?These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed.
Okay, I didn't know that. I just observed that the original patch was sent before the the MS VSDB parsing was added.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 46 lines · Jani Nikula
Quoted 45 lines · Dmitry Osipenko
Quoted 43 lines · Jani Nikula
Quoted 31 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 10 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0drivers/gpu/drm/drm_edid.c static const struct edid_quirk { · line 203
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 4 lines
drivers/gpu/drm/drm_edid.c +1
-0EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), + EDID_QUIRK('H', 'V', 'R', 0xaa04, EDID_QUIRK_NON_DESKTOP),Quoted 7 lines
Quoted 4 lines
drivers/gpu/drm/drm_edid.c +0
-0/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See
2869f599c0d8("drm/edid: support Microsoft extension for HMDs and specialized monitors").
Quoted 7 lines
Quoted 4 lines
Do you mean to skip using the
EDID_QUIRK_NON_DESKTOPif MS VSDB entry presents in the EDID?These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed.
Okay, I didn't know that. I just observed that the original patch was sent before the the MS VSDB parsing was added.
This will be good to mention in the v2 commit message.
Signature · 2 lines
Best regards, Dmitry
Quoted 50 lines · Dmitry Osipenko
Quoted 49 lines · Jani Nikula
Quoted 48 lines · Dmitry Osipenko
Quoted 35 lines · Jani Nikula
Quoted 34 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 10 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>--- drivers/gpu/drm/drm_edid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0drivers/gpu/drm/drm_edid.c static const struct edid_quirk { · line 203
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -200,9 +200,10 @@ static const struct edid_quirk {EDID_QUIRK ('V' ,'L' ,'V' ,0x91be ,EDID_QUIRK_NON_DESKTOP ), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP), -/* HTC Vive and Vive Pro VR Headsets */ +/* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */ Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 7 lines
drivers/gpu/drm/drm_edid.c +1
-0EDID_QUIRK ('H' ,'V' ,'R' ,0xaa01 ,EDID_QUIRK_NON_DESKTOP ),EDID_QUIRK ('H' ,'V' ,'R' ,0xaa02 ,EDID_QUIRK_NON_DESKTOP ), +EDID_QUIRK ('H' ,'V' ,'R' ,0xaa04 ,EDID_QUIRK_NON_DESKTOP ),/* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */ EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),Quoted 8 lines
Quoted 4 lines
Quoted 1 line
base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See
2869f599c0d8("drm/edid: support Microsoft extension for HMDs and specialized monitors").Do you mean to skip using the
EDID_QUIRK_NON_DESKTOPif MS VSDB entry presents in the EDID?
Quoted 7 lines
Quoted 4 lines
Quoted 1 line
These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed.
Okay, I didn't know that. I just observed that the original patch was sent before the the MS VSDB parsing was added.
This will be good to mention in the v2 commit message.
This headset does support some kind of HMD signalling, however, this is not a microsoft-specific extension (0xca125c) but part of the DisplayId spec, "Display Product Primary Use Case" field is set to "7".
The problem is, I have no idea what spec I should refer to, as I can't find this errata in the original spec, and the only reference to this value I see is in https://git.linuxtv.org/edid-decode.git utility:
I would like to implement this feature, but I need some spec reference.
Quoted 64 lines · Iaroslav Boliukin
Quoted 50 lines · Dmitry Osipenko
Quoted 49 lines · Jani Nikula
Quoted 47 lines · Dmitry Osipenko
Quoted 34 lines · Jani Nikula
Quoted 32 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 12 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>---
drivers/gpu/drm/drm_edid.c| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0@@ -200,9 +200,10 @@ static const struct edid_quirk { EDID_QUIRK('V', 'L', 'V', 0x91be, EDID_QUIRK_NON_DESKTOP), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP),Quoted 2 lines
- /* HTC Vive and Vive Pro VR Headsets */ + /* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */
Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 6 lines
EDID_QUIRK('H', 'V', 'R', 0xaa01, EDID_QUIRK_NON_DESKTOP),EDID_QUIRK('H', 'V', 'R', 0xaa02, EDID_QUIRK_NON_DESKTOP), +EDID_QUIRK('H', 'V', 'R', 0xaa04, EDID_QUIRK_NON_DESKTOP), /* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),Quoted 8 lines
Quoted 4 lines
Quoted 1 line
base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See
2869f599c0d8("drm/edid: support Microsoft extension for HMDs and specialized monitors").Do you mean to skip using the
EDID_QUIRK_NON_DESKTOPif MS VSDB entry presents in the EDID?Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed.
Okay, I didn't know that. I just observed that the original patch was sent before the the MS VSDB parsing was added.
This will be good to mention in the v2 commit message.
This headset does support some kind of HMD signalling, however, this is not a microsoft-specific extension (
0xca125c) but part of the DisplayId spec, "Display Product Primary Use Case" field is set to "7".
Quoted 7 lines
The problem is, I have no idea what spec I should refer to, as I can't find this errata in the original spec, and the only reference to this value I see is in https://git.linuxtv.org/edid-decode.git utility:
I would like to implement this feature, but I need some spec reference.
The [1] says it's "VESA DisplayID Standard v2.0", which should be okay to refer, IMO.
Signature · 2 lines
Best regards, Dmitry
Quoted 58 lines · Dmitry Osipenko
Quoted 57 lines · Iaroslav Boliukin
Quoted 56 lines · Dmitry Osipenko
Quoted 54 lines · Jani Nikula
Quoted 44 lines · Dmitry Osipenko
Quoted 34 lines · Jani Nikula
Quoted 32 lines · Dmitry Osipenko
Hi,
On 1/18/22 20:00, Yaroslav Bolyukin wrote:
Add a brief commit message, describing a user-visible effect of this patch. Tell that this change prevents exposing headset as a regular display to the system, while it will work with SteamVR.
Quoted 12 lines
Signed-off-by Yaroslav Bolyukin <[email protected]>---
drivers/gpu/drm/drm_edid.c| 3 ++-1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0@@ -200,9 +200,10 @@ static const struct edid_quirk { EDID_QUIRK('V', 'L', 'V', 0x91be, EDID_QUIRK_NON_DESKTOP), EDID_QUIRK('V', 'L', 'V', 0x91bf, EDID_QUIRK_NON_DESKTOP),Quoted 2 lines
- /* HTC Vive and Vive Pro VR Headsets */ + /* HTC Vive, Vive Pro and Vive Pro 2 VR Headsets */
Nit: I'd keep the original comment, or change it to a generic "HTC VR Headsets" to prevent further comment changes
Quoted 6 lines
EDID_QUIRK('H', 'V', 'R', 0xaa01, EDID_QUIRK_NON_DESKTOP),EDID_QUIRK('H', 'V', 'R', 0xaa02, EDID_QUIRK_NON_DESKTOP), +EDID_QUIRK('H', 'V', 'R', 0xaa04, EDID_QUIRK_NON_DESKTOP), /* Oculus Rift DK1, DK2, CV1 and Rift S VR Headsets */EDID_QUIRK('O', 'V', 'R', 0x0001, EDID_QUIRK_NON_DESKTOP),Quoted 8 lines
Quoted 4 lines
Quoted 1 line
base-commit:
99613159ad749543621da8238acf1a122880144ePlease send the v2 patch with the added EDID for Cosmos VR and the addressed comments. Thanks!
Yeah, we'll need to EDID to check that it doesn't have the Microsoft VSDB to indicate non-desktop. See
2869f599c0d8("drm/edid: support Microsoft extension for HMDs and specialized monitors").Quoted 5 lines
Do you mean to skip using the
EDID_QUIRK_NON_DESKTOPif MS VSDB entry presents in the EDID?These HTC EDIDs don't have MS VSDB, otherwise the quirk wouldn't be needed.
Okay, I didn't know that. I just observed that the original patch was sent before the the MS VSDB parsing was added.
Quoted 6 lines
Quoted 6 lines
Quoted 2 lines
This will be good to mention in the v2 commit message.
This headset does support some kind of HMD signalling, however, this is not a microsoft-specific extension (
0xca125c) but part of the DisplayId spec, "Display Product Primary Use Case" field is set to "7".
I just sent patches to hopefully fix this, and make the quirk unnecessary [1].
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/114116/
Quoted 14 lines
Quoted 8 lines
The problem is, I have no idea what spec I should refer to, as I can't find this errata in the original spec, and the only reference to this value I see is in https://git.linuxtv.org/edid-decode.git utility:
I would like to implement this feature, but I need some spec reference.
The [1] says it's "VESA DisplayID Standard v2.0", which should be okay to refer, IMO.
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center