Skip to contentSkip to conversation

kernel: add missing path to search for debug files

PATCH In review Andrej Valek 3 participants 5 messages Jan 19, 2022 – May 12, 2022 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel: add missing path to search for debug files

Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE options. For ex. when the variable "debug-file-directory" package search path has to be set explicitly, otherwise it will not find any files.

---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +1 -0
index 473e28be47..9ea201c936 100644
@@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
 FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
 FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
 FILES:${KERNEL_PACKAGE_NAME}-modules = ""
+FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"
 RDEPENDS:${KERNEL_PACKAGE_NAME} = "${KERNEL_PACKAGE_NAME}-base (= ${EXTENDPKGV})"
 # Allow machines to override this dependency if kernel image files are
 # not wanted in images as standard
Signature · 1 line
2.31.1
#1 lore raw
Quoted 15 lines · Andrej Valek

Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE options. For ex. when the variable "debug-file-directory" package search path has to be set explicitly, otherwise it will not find any files.

---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +0 -0
index 473e28be47..9ea201c936 100644

meta/classes/kernel.bbclass FILES:${KERNEL_PACKAGE_NAME}-image = "" · line 650

Quoted 4 lines
meta/classes/kernel.bbclass +1 -0
@@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
 FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
 FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
 FILES:${KERNEL_PACKAGE_NAME}-modules = ""
+FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"

This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the very least we need a bugzilla entry for creating some...

Cheers,

Richard

#2 lore raw
Quoted 11 lines · Richard Purdie
Quoted 10 lines · Andrej Valek

Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE options. For ex. when the variable "debug-file-directory" package search path has to be set explicitly, otherwise it will not find any files.

---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

meta/classes/kernel.bbclass FILES:${KERNEL_PACKAGE_NAME}-image = "" · line 650

Quoted 9 lines
meta/classes/kernel.bbclass +1 -0
index 473e28be47..9ea201c936 100644
@@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
 FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
 FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
 FILES:${KERNEL_PACKAGE_NAME}-modules = ""
+FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"

This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the very least we need a bugzilla entry for creating some...

Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700
Cheers
Michael

Signature · 3 lines
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

Hello Richard,

Fine, that we have it, but are you going to take a look on the patch :) ?

Regards,
Andrej

Quoted 40 lines · Michael Opdenacker
Quoted 24 lines · Richard Purdie
Quoted 23 lines · Andrej Valek

Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}- dbg has
been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE
options. For ex. when the variable "debug-file-directory" package search
path has to be set explicitly, otherwise it will not find any files.

---
 meta/classes/kernel.bbclass | 1 +

 1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +0 -0
index 473e28be47..9ea201c936 100644
@@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""

 FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"

Quoted 8 lines
Quoted 5 lines

 FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux- ${KERNEL_VERSION_NAME}" FILES:${KERNEL_PACKAGE_NAME}-modules = "" +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"

This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the
very least we need a bugzilla entry for creating some...

Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700
Cheers
Michael

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

ping

Quoted 65 lines · Andrej Valek via lists.openembedded.org

Hello Richard,

Fine, that we have it, but are you going to take a look on the patch :)
?

Regards,
Andrej

Quoted 38 lines · Michael Opdenacker
Quoted 26 lines · Richard Purdie
Quoted 25 lines · Andrej Valek

Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-
dbg has
been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE
options. For ex. when the variable "debug-file-directory" package
search
path has to be set explicitly, otherwise it will not find any files.

---
 meta/classes/kernel.bbclass | 1 +

 1 file changed, 1 insertion(+)
meta/classes/kernel.bbclass +0 -0
index 473e28be47..9ea201c936 100644
@@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""

 FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"

Quoted 8 lines
Quoted 5 lines

 FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux- ${KERNEL_VERSION_NAME}" FILES:${KERNEL_PACKAGE_NAME}-modules = "" +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"

This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the
very least we need a bugzilla entry for creating some...

Quoted 4 lines

Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700
Cheers
Michael

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group. View/Reply Online (#160872):
https://lists.openembedded.org/g/openembedded-core/message/160872
Mute This Topic: https://lists.openembedded.org/mt/88532225/3619876
Group Owner: [email protected] Unsubscribe:
https://lists.openembedded.org/g/openembedded-core/unsub [
[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-