Skip to contentSkip to conversation

amd/amdkfd:Fix the return value in kfd_process_queue_manager

PATCH In review majun 2 participants 3 messages Jan 19, 2022 – Jan 20, 2022

Subsystems (3)
lore
Share & tools
lore

majun

author
#0 lore raw

PATCH 1/1 amd/amdkfd:Fix the return value in kfd_process_queue_manager

Change the return value of set_queue_properties_from_criu()

Change-Id I11362eb76eee84e64c5207c24a2b78141f62e63a
---
 drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +1 -1
index ec62897914da..f70e972d1d33 100644
@@ -826,7 +826,7 @@ static void set_queue_properties_from_criu(struct queue_properties *qp,
 	qp->type = q_data->type;
 	qp->format = q_data->format;
 
-	return 0;
+	return;
 }
 
 
Signature · 1 line
2.25.1
#1 lore raw

[AMD Official Use Only]

You can just drop the whole line.

Alex

________________________________
From: amd-gfx <[email protected]> on behalf of majun <[email protected]>
Sent: Wednesday, January 19, 2022 7:57 AM
To: [email protected] <[email protected]>
Subject: [PATCH] amd/amdkfd:Fix the return value in kfd_process_queue_manager

Change the return value of set_queue_properties_from_criu()

Change-Id I11362eb76eee84e64c5207c24a2b78141f62e63a
---
 drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +1 -1
index ec62897914da..f70e972d1d33 100644
@@ -826,7 +826,7 @@ static void set_queue_properties_from_criu(struct queue_properties *qp,
         qp->type = q_data->type;
         qp->format = q_data->format;
 
-       return 0;
+       return;
 }
 
 

--
2.25.1

author
#2 lore raw

Yes, return is not necessary here.
I'll apply this patch on dkms-staging to fix the compile error.

Quoted 37 lines · Alexander

[AMD Official Use Only]

You can just drop the whole line.

Alex

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
*From:* amd-gfx <[email protected]> on behalf of majun <[email protected]> *Sent:* Wednesday, January 19, 2022 7:57 AM
*To:* [email protected] <[email protected]> *Subject:* [PATCH] amd/amdkfd:Fix the return value in kfd_process_queue_manager
Change the return value of set_queue_properties_from_criu()

Change-Id I11362eb76eee84e64c5207c24a2b78141f62e63a

---
 drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +0 -0
index ec62897914da..f70e972d1d33 100644
@@ -826,7 +826,7 @@ static void set_queue_properties_from_criu(struct queue_properties *qp,
          qp->type = q_data->type;
          qp->format = q_data->format;


-       return 0;
+       return;
 }

Signature · 1 line
2.25.1