Skip to contentSkip to conversation

dpp: free nl80211 object on exit

PATCH In review James Prestwood 2 participants 3 messages Jan 19, 2022

lore
Share & tools
lore

James Prestwood

author
#0 lore raw

PATCH 1/2 dpp: free nl80211 object on exit

---
 src/dpp.c | 3 +++
 1 file changed, 3 insertions(+)
src/dpp.c +3 -0
index 78e8ffc5..6889bef9 100644
@@ -1931,6 +1931,9 @@ static void dpp_exit(void)
 	l_genl_family_unregister(nl80211, mlme_watch);
 	mlme_watch = 0;
 
+	l_genl_family_free(nl80211);
+	nl80211 = NULL;
+
 	l_queue_destroy(dpp_list, (l_queue_destroy_func_t) dpp_free);
 }
 
Signature · 1 line
2.31.1
author
#1 lore raw

PATCH 2/2 test-runner: set --show-leak-kinds=all

This enables leak checks starting in main() which were previously ignored.

---
 tools/test-runner | 1 +
 1 file changed, 1 insertion(+)
tools/test-runner +1 -0
index c35466c1..7176deaf 100755
@@ -673,6 +673,7 @@ class Namespace:
 
 		if self.args.valgrind:
 			args.extend(['valgrind', '--leak-check=full', '--track-origins=yes',
+					'--show-leak-kinds=all',
 					'--log-file=/tmp/valgrind.log.%p'])
 
 		args.extend(['iwd', '-p', iwd_radios, '-E'])
Signature · 1 line
2.31.1
#2 lore raw
In reply to James Prestwood

Hi James,

Quoted 3 lines · James Prestwood
---
  src/dpp.c | 3 +++
  1 file changed, 3 insertions(+)

Both applied, thanks.

Regards,
-Denis