Skip to contentSkip to conversation

GitHub Actions: add other config flavours

PATCH Superseded Antonio Quartulli 2 participants 4 messages Jan 19, 2022 – Jan 21, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 GitHub Actions: add other config flavours

In the past we had issues with patches accidentally breaking less common OpenVPN configurations. For this reason it makes sense to some of those configurations build via CI.

Adding:
* --enable-iproute2
* --enable-async-push
* --disable-management
* --enable-small
* --disable-lzo
* --disable-lz4

These flavours are all built on Ubuntu 20.04 with OpenSSL 1.1.1

---

The GH Actions run for this patch can be found at:
https://github.com/ordex/openvpn/actions/runs/1719339028

 .github/workflows/build.yaml | 34 ++++++++++++++++++++++++++++++++--
 1 file changed, 32 insertions(+), 2 deletions(-)
.github/workflows/build.yaml +32 -2
index 354a3256..a47b3481 100644
@@ -148,8 +148,38 @@ jobs:
             sslpkg: "libssl-dev"
             libname: OpenSSL 1.1.1
             ssllib: openssl
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-iproute2"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-async-push"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-management"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-small"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-lzo"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-lz4"
 
-    name: "gcc - ${{matrix.os}} - ${{matrix.libname}}"
+    name: "gcc - ${{matrix.os}} - ${{matrix.libname}} ${{matrix.extraconf}}"
     env:
       SSLPKG: "${{matrix.sslpkg}}"
 
@@ -162,7 +192,7 @@ jobs:
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
-        run: ./configure --with-crypto-library=${{matrix.ssllib}}
+        run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}}
       - name: make all
         run: make -j3
       - name: make check
Signature · 1 line
2.34.1
#1 lore raw

Hi,

Quoted 2 lines · Antonio Quartulli

* --disable-lzo
* --disable-lz4

Not sure having them individually does much good, but we definitely want a config with "disable all compression" (--disable-lzo --disable-lz4).

This was what we broke last time :-)

(And it might actually still be broken at run time... MaxF?)

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...
#2 lore raw

PATCH v2 1/1 GitHub Actions: add other config flavours

In reply to Antonio Quartulli

In the past we had issues with patches accidentally breaking less common OpenVPN configurations. For this reason it makes sense to some of those configurations build via CI.

Adding:
* --enable-iproute2
* --enable-async-push
* --disable-management
* --enable-small
* --disable-lzo --disable-lz4

These flavours are all built on Ubuntu 20.04 with OpenSSL 1.1.1

---

v2:
* combined --disable-lzo and --disable-lz4 in one single build

 .github/workflows/build.yaml | 29 +++++++++++++++++++++++++++--
 1 file changed, 27 insertions(+), 2 deletions(-)
.github/workflows/build.yaml +27 -2
index 354a3256..9f884ac2 100644
@@ -148,8 +148,33 @@ jobs:
             sslpkg: "libssl-dev"
             libname: OpenSSL 1.1.1
             ssllib: openssl
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-iproute2"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-async-push"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-management"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--enable-small"
+          - os: ubuntu-20.04
+            sslpkg: "libssl-dev"
+            libname: OpenSSL 1.1.1
+            ssllib: openssl
+            extraconf: "--disable-lzo --disable-lz4"
 
-    name: "gcc - ${{matrix.os}} - ${{matrix.libname}}"
+    name: "gcc - ${{matrix.os}} - ${{matrix.libname}} ${{matrix.extraconf}}"
     env:
       SSLPKG: "${{matrix.sslpkg}}"
 
@@ -162,7 +187,7 @@ jobs:
       - name: autoconf
         run: autoreconf -fvi
       - name: configure
-        run: ./configure --with-crypto-library=${{matrix.ssllib}}
+        run: ./configure --with-crypto-library=${{matrix.ssllib}} ${{matrix.extraconf}}
       - name: make all
         run: make -j3
       - name: make check
Signature · 1 line
2.34.1
Acked-by on v2 1/1
#3 lore raw

Sounds useful. We should not overdo the "burn energy for testing build variants" thing, but "not test problematic variants" is not good either.

Your patch has been applied to the master branch.

commit 8ee0997abd0642c4c4a6135573beba647d982f7c

Author: Antonio Quartulli
Date:   Fri Jan 21 14:39:00 2022 +0100
     GitHub Actions: add other config flavours

     Signed-off-by: Antonio Quartulli <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg23624.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering