drm/amdgpu: enable amdgpu_dc module parameter
Subsystems (2)
PATCH 1/1 drm/amdgpu: enable amdgpu_dc module parameter
It doesn't work under IP discovery mode. Make it work!
Signed-off-by Lang Yu <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +8 -2
@@ -846,8 +846,14 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) {if (adev->enable_virtual_display ||amdgpu_sriov_vf (adev)) {amdgpu_device_ip_block_add (adev, &amdgpu_vkms_ip_block); +return 0 ; + } + +if (!amdgpu_device_has_dc_support (adev)) +return 0 ; +#if defined(CONFIG_DRM_AMD_DC ) - } else if (adev->ip_versions[DCE_HWIP][0]) { +if (adev->ip_versions[DCE_HWIP ][0 ]) {switch (adev->ip_versions[DCE_HWIP ][0 ]) {case IP_VERSION (1 ,0 ,0 ):case IP_VERSION (1 ,0 ,1 ):
@@ -882,9 +888,9 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) adev->ip_versions[DCI_HWIP][0]); return -EINVAL; } -#endif }return 0 ; +#endif }static int amdgpu_discovery_set_gc_ip_blocks (struct amdgpu_device *adev)
Signature · 1 line
2.25.1
Quoted 29 lines · Lang Yu
It doesn't work under IP discovery mode. Make it work!
Signed-off-by Lang Yu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +7
-1@@ -846,8 +846,14 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) {if (adev->enable_virtual_display ||amdgpu_sriov_vf (adev)) {amdgpu_device_ip_block_add (adev, &amdgpu_vkms_ip_block); +return 0 ; + } + +if (!amdgpu_device_has_dc_support (adev)) +return 0 ; +#if defined(CONFIG_DRM_AMD_DC ) - } else if (adev->ip_versions[DCE_HWIP][0]) { +if (adev->ip_versions[DCE_HWIP ][0 ]) {switch (adev->ip_versions[DCE_HWIP ][0 ]) {case IP_VERSION (1 ,0 ,0 ):case IP_VERSION (1 ,0 ,1 ):
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) · line 893
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +1
-1@@ -882,9 +888,9 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) adev->ip_versions[DCI_HWIP][0]); return -EINVAL; } -#endif }return 0 ; +#endif
I think the compiler will complain about this. If you move the #endif before the return, the patch is:
Reviewed-by Alex Deucher <[email protected]>
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +0
-1}static int amdgpu_discovery_set_gc_ip_blocks (struct amdgpu_device *adev) --2.25.1
Quoted 40 lines · Alex Deucher
Quoted 29 lines · Lang Yu
It doesn't work under IP discovery mode. Make it work!
Signed-off-by Lang Yu <[email protected]>--- drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +7
-1@@ -846,8 +846,14 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) {if (adev->enable_virtual_display ||amdgpu_sriov_vf (adev)) {amdgpu_device_ip_block_add (adev, &amdgpu_vkms_ip_block); +return 0 ; + } + +if (!amdgpu_device_has_dc_support (adev)) +return 0 ; +#if defined(CONFIG_DRM_AMD_DC ) - } else if (adev->ip_versions[DCE_HWIP][0]) { +if (adev->ip_versions[DCE_HWIP ][0 ]) {switch (adev->ip_versions[DCE_HWIP ][0 ]) {case IP_VERSION (1 ,0 ,0 ):case IP_VERSION (1 ,0 ,1 ):drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) · line 893
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +1
-1@@ -882,9 +888,9 @@ static int amdgpu_discovery_set_display_ip_blocks(struct amdgpu_device *adev) adev->ip_versions[DCI_HWIP][0]); return -EINVAL; } -#endif }return 0 ; +#endif I think the compiler will complain about this. If you move the #endif before the return, the patch is:
Quoted 1 line
Reviewed-by Alex Deucher <[email protected]>
Thanks. I got it.
Regards,
Lang
Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c +0
-1}static int amdgpu_discovery_set_gc_ip_blocks (struct amdgpu_device *adev) --2.25.1