Skip to contentSkip to conversation

KVM: compat: riscv: Prevent KVM_COMPAT from being selected

PATCH Superseded [email protected] 2 participants 3 messages Jan 20, 2022 – Jan 21, 2022

Subsystems (5)
KVM MIPS RISC-V s390 +1 more subsystems

v3 of 12 Superseded Latest is v12 →

lore
Share & tools
lore

[email protected]

author maintainer
#0 lore raw

PATCH v3 17/17 KVM: compat: riscv: Prevent KVM_COMPAT from being selected

From: Guo Ren <[email protected]>

Current riscv doesn't support the 32bit KVM/arm API. Let's make it clear by not selecting KVM_COMPAT.

---
 virt/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/Kconfig +1 -1
index f4834c20e4a6..a8c5c9f06b3c 100644
@@ -53,7 +53,7 @@ config KVM_GENERIC_DIRTYLOG_READ_PROTECT
 
 config KVM_COMPAT
        def_bool y
-       depends on KVM && COMPAT && !(S390 || ARM64)
+       depends on KVM && COMPAT && !(S390 || ARM64 || RISCV)
 
 config HAVE_KVM_IRQ_BYPASS
        bool
Signature · 1 line
2.25.1
#1 lore raw
Quoted 16 lines · On Thu, Jan 20, 2022 at 8:39 AM <[email protected]> wrote:

From: Guo Ren <[email protected]>

Current riscv doesn't support the 32bit KVM/arm API. Let's make it clear by not selecting KVM_COMPAT.

---
 virt/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/Kconfig +0 -0
index f4834c20e4a6..a8c5c9f06b3c 100644

virt/kvm/Kconfig config KVM_GENERIC_DIRTYLOG_READ_PROTECT · line 56

Quoted 5 lines
virt/kvm/Kconfig +1 -1
@@ -53,7 +53,7 @@ config KVM_GENERIC_DIRTYLOG_READ_PROTECT
 
 config KVM_COMPAT
        def_bool y
-       depends on KVM && COMPAT && !(S390 || ARM64)
+       depends on KVM && COMPAT && !(S390 || ARM64 || RISCV)

Maybe this should be flipped around into a positive list now? The remaining architectures would be mips, powerpc and x86, but it's unclear if this actually meant to work on all of them, or any potential ones added in the
future.

Arnd

author maintainer
#2 lore raw
Quoted 19 lines · Arnd Bergmann
Quoted 17 lines · On Thu, Jan 20, 2022 at 8:39 AM <[email protected]> wrote:

From: Guo Ren <[email protected]>

Current riscv doesn't support the 32bit KVM/arm API. Let's make it clear by not selecting KVM_COMPAT.

---
 virt/kvm/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/Kconfig +0 -0
index f4834c20e4a6..a8c5c9f06b3c 100644
@@ -53,7 +53,7 @@ config KVM_GENERIC_DIRTYLOG_READ_PROTECT
 
Quoted 6 lines

virt/kvm/Kconfig config KVM_GENERIC_DIRTYLOG_READ_PROTECT · line 56

Quoted 4 lines
virt/kvm/Kconfig +1 -1
 config KVM_COMPAT
        def_bool y
-       depends on KVM && COMPAT && !(S390 || ARM64)
+       depends on KVM && COMPAT && !(S390 || ARM64 || RISCV)

Maybe this should be flipped around into a positive list now?

I think it's another patch to do that. Not in this series.

Quoted 3 lines

The remaining architectures would be mips, powerpc and x86, but it's unclear if this actually meant to work on all of them, or any potential ones added in the

Yes, it's unclear and arch maintainers need to confirm that.

Quoted 3 lines

future.

Arnd

Signature · 4 lines
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/