parisc: pdc_stable: Fix memory leak in pdcs_register_pathentries
PATCH 1/1 parisc: pdc_stable: Fix memory leak in pdcs_register_pathentries
kobject_init_and_add() takes reference even when it fails. According to the doc of kobject_init_and_add():
If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object.
Fix memory leak by calling kobject_put().
Fixes 73f368cf679b ("Kobject: change drivers/parisc/pdc_stable.c to use kobject_init_and_add")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/parisc/pdc_stable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/parisc/pdc_stable.c +3 -1
@@ -980,8 +980,10 @@ pdcs_register_pathentries(void) entry->kobj.kset = paths_kset; err =kobject_init_and_add (&entry->kobj, &ktype_pdcspath,NULL ,"%s" , entry->name); -if (err) +if (err) { +kobject_put (&entry->kobj);return err; + }/* kobject is now registered */ write_lock (&entry->rw_lock);
Signature · 1 line
2.17.1
Quoted 10 lines · Miaoqian Lin
kobject_init_and_add()takes reference even when it fails. According to the doc of kobject_init_and_add():If this function returns an error,
kobject_put()must be called to properly clean up the memory associated with the object.Fix memory leak by calling
kobject_put().Fixes 73f368cf679b ("Kobject: change drivers/parisc/pdc_stable.c to use kobject_init_and_add")Signed-off-by Miaoqian Lin <[email protected]>
applied.
Thanks!
Helge
Quoted 21 lines
--- drivers/parisc/pdc_stable.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/parisc/pdc_stable.c +3
-1@@ -980,8 +980,10 @@ pdcs_register_pathentries(void) entry->kobj.kset = paths_kset; err =kobject_init_and_add (&entry->kobj, &ktype_pdcspath,NULL ,"%s" , entry->name); -if (err) +if (err) { +kobject_put (&entry->kobj);return err; + }/* kobject is now registered */ write_lock (&entry->rw_lock);