Skip to contentSkip to conversation

configs/kontron_pitx_imx8m_defconfig: remove BR2_ARM_FPU_VFPV3

PATCH Applied Heiko Thiery 2 participants 3 messages Jan 20, 2022 – Jan 22, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs/kontron_pitx_imx8m_defconfig: remove BR2_ARM_FPU_VFPV3

The FP setting is not used for aarch64 in buildroot. The FPU options are set implicit.

---
 configs/kontron_pitx_imx8m_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/kontron_pitx_imx8m_defconfig +0 -1
index 7f9c0eeae8..8f756f5246 100644
@@ -1,6 +1,5 @@
 # Architecture
 BR2_aarch64=y
-BR2_ARM_FPU_VFPV3=y
 
 # System
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc2"
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 7 lines · On Thu, 20 Jan 2022 14:52:52 +0100 Heiko Thiery <[email protected]> wrote:

The FP setting is not used for aarch64 in buildroot. The FPU options are set implicit.

---
 configs/kontron_pitx_imx8m_defconfig | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks. That being said the FPU handling on AArch64 is not very clear to me. I'm not sure we're handling it correctly in Buildroot today.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Hi Thomas,

Am Sa., 22. Jan. 2022 um 13:15 Uhr schrieb Thomas Petazzoni <[email protected]>:

Quoted 7 lines
Quoted 3 lines · On Thu, 20 Jan 2022 14:52:52 +0100 Heiko Thiery <[email protected]> wrote:

The FP setting is not used for aarch64 in buildroot. The FPU options are set implicit.

Quoted 8 lines
Quoted 4 lines
---
 configs/kontron_pitx_imx8m_defconfig | 1 -
 1 file changed, 1 deletion(-)

Applied to master, thanks. That being said the FPU handling on AArch64 is not very clear to me. I'm not sure we're handling it correctly in Buildroot today.

I must admit that I have not fully understood the topic FPU either. What I am sure of is that the kconfig selection of the "Floating point stategy" option for aarch64 has no effect, since this setting is made implicitly depending on the target architecture used.

Therefore, a patch could look something like this to fix this:

arch/Config.in.arm +1 -0
index 4c0910e4f8..05acaa9157 100644
@@ -618,6 +618,7 @@ endchoice
 
 choice
        prompt "Floating point strategy"
+      depends on BR2_arm || BR2_armeb
        default BR2_ARM_FPU_FP_ARMV8 if BR2_ARM_CPU_HAS_FP_ARMV8
        default BR2_ARM_FPU_FPV5D16 if BR2_ARM_CPU_HAS_FPV5
        default BR2_ARM_FPU_FPV4D16 if BR2_ARM_CPU_HAS_FPV4
Signature · 5 lines
Heiko
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot