Skip to contentSkip to conversation

fs-ioctl-remove-unnecessary-__user-annotation.patch removed from -mm tree

merged [email protected] 1 participant 1 message Jan 20, 2022

lore
Share & tools
lore

[email protected]

author tree notice Applied
#0 lore raw

The patch titled
Subject: fs/ioctl: remove unnecessary __user annotation
has been removed from the -mm tree. Its filename was
fs-ioctl-remove-unnecessary-__user-annotation.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Amit Daniel Kachhap <[email protected]>
Subject: fs/ioctl: remove unnecessary __user annotation

__user annotations are used by the checker (e.g sparse) to mark user pointers. However here __user is applied to a struct directly, without a pointer being directly involved.

Although the presence of __user does not cause sparse to emit a warning, __user should be removed for consistency with other uses of offsetof().

Note: No functional changes intended.

---

 fs/ioctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ioctl.c renamed from fs/ioctl.c~fs-ioctl-remove-unnecessary-__user-annotation +1 -1
@@ -430,7 +430,7 @@ static int ioctl_file_dedupe_range(struc
 		goto out;
 	}
 
-	size = offsetof(struct file_dedupe_range __user, info[count]);
+	size = offsetof(struct file_dedupe_range, info[count]);
 	if (size > PAGE_SIZE) {
 		ret = -ENOMEM;
 		goto out;

_

Patches currently in -mm which might be from [email protected] are