Skip to contentSkip to conversation

btrfs-progs: make generic_err print physical address of extent buffer

PATCH In review Su Yue 2 participants 2 messages Jan 21, 2022 – Jan 25, 2022 Btrfs file system

lore
Share & tools
lore

Su Yue

author
#0 lore raw

PATCH 1/1 btrfs-progs: make generic_err print physical address of extent buffer

Unlike kernel, we have cached physical address of extent_buffer in dev_bytenr. Print it for better debug experience.

---
 kernel-shared/ctree.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
kernel-shared/ctree.c +3 -2
index 21e5414965e7..950923d03165 100644
@@ -590,9 +590,10 @@ static void generic_err(const struct extent_buffer *buf, int slot,
 {
 	va_list args;
 
-	fprintf(stderr, "corrupt %s: root=%lld block=%llu slot=%d, ",
+	fprintf(stderr, "corrupt %s: root=%lld block=%llu physical=%llu slot=%d, ",
 		btrfs_header_level(buf) == 0 ? "leaf": "node",
-		btrfs_header_owner(buf), btrfs_header_bytenr(buf), slot);
+		btrfs_header_owner(buf), btrfs_header_bytenr(buf),
+		buf->dev_bytenr, slot);
 	va_start(args, fmt);
 	vfprintf(stderr, fmt, args);
 	va_end(args);
Signature · 1 line
2.34.1
#1 lore raw
Quoted 4 lines · Su Yue

Unlike kernel, we have cached physical address of extent_buffer in dev_bytenr. Print it for better debug experience.

Added to devel, thanks.