aiodio: Skip tests on tmpfs
PATCH 1/1 aiodio: Skip tests on tmpfs
tmpfs does not support it.
--- testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++-- testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++ testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++ testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++-- testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++-- 5 files changed, 32 insertions(+), 6 deletions(-)
testcases/kernel/io/ltp-aiodio/aiodio_append.c +8 -2
@@ -131,8 +131,10 @@ static void setup(void)static void cleanup (void ) { - *run_child =0 ; -SAFE_MUNMAP (run_child,sizeof (int )); +if (run_child) { + *run_child =0 ; +SAFE_MUNMAP (run_child,sizeof (int )); + } }static void run (void )
@@ -177,6 +179,10 @@ static struct tst_test test = { {"b:", &str_numaio, "Number of async IO blocks (default 16)"}, {} }, + .skip_filesystems = (const char *[]) { + "tmpfs", + NULL + }, }; #else TST_TEST_TCONF("test requires libaio and its development packages");
testcases/kernel/io/ltp-aiodio/dio_append.c +4 -0
@@ -93,4 +93,8 @@ static struct tst_test test = { {"c:", &str_appends, "Number of appends (default 1000)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };
testcases/kernel/io/ltp-aiodio/dio_read.c +4 -0
@@ -177,4 +177,8 @@ static struct tst_test test = { {"s:", &str_filesize, "File size (default 128M)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };
testcases/kernel/io/ltp-aiodio/dio_sparse.c +8 -2
@@ -83,8 +83,10 @@ static void setup(void)static void cleanup (void ) { - *run_child =0 ; -SAFE_MUNMAP (run_child,sizeof (int )); +if (run_child) { + *run_child =0 ; +SAFE_MUNMAP (run_child,sizeof (int )); + } }static void run (void )
@@ -129,4 +131,8 @@ static struct tst_test test = { {"o:", &str_offset, "File offset (default 0)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };
testcases/kernel/io/ltp-aiodio/dio_truncate.c +8 -2
@@ -107,8 +107,10 @@ static void setup(void)static void cleanup (void ) { - *run_child =0 ; -SAFE_MUNMAP (run_child,sizeof (int )); +if (run_child) { + *run_child =0 ; +SAFE_MUNMAP (run_child,sizeof (int )); + } }static void run (void )
@@ -163,4 +165,8 @@ static struct tst_test test = { {"c:", &str_numwrites, "Number of append & truncate (default 100)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };
Signature · 5 lines
2.34.1 -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi all,
[Cc Li ]
Quoted 1 line
tmpfs does not support it.
Verifying with .all_filesystems, that only tmpfs is problematic
- tested on exfat, ntfs over FUSE, vfat (common linux filesystems obviously work)
That's why I avoided opening file with O_DIRECT in setup().
BTW I wonder what is the reason of duplicate entries in ltp-aiodio.part4? i.e. dio_sparse, aiodio_append, dio_append, dio_truncate... To create bigger load?
IMHO it'd make sense to run at least one test on .all_filesystems to check more filesystems (dio_append seems to be quick), but I wouldn't done it when there are duplicate entries.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 6 lines
Quoted 1 line
tmpfs does not support it.
Verifying with .all_filesystems, that only tmpfs is problematic
- tested on exfat, ntfs over FUSE, vfat (common linux filesystems obviously work)That's why I avoided opening file with
O_DIRECTinsetup().
Quoted 7 lines
BTW I wonder what is the reason of duplicate entries in ltp-aiodio.part4? i.e.
dio_sparse,aiodio_append,dio_append,dio_truncate... To create bigger load?IMHO it'd make sense to run at least one test on .all_filesystems to check more filesystems (
dio_appendseems to be quick), but I wouldn't done it when there are duplicate entries.
Historicall mess I guess. We will clean that up in the next development cycle.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 5 lines · Petr Vorel
Hi all,
[Cc Li ]
Quoted 1 line
tmpfs does not support it.
Quoted 8 lines
Verifying with .all_filesystems, that only tmpfs is problematic
- tested on exfat, ntfs over FUSE, vfat (common linux filesystems obviously work)That's why I avoided opening file with
O_DIRECTinsetup().BTW I wonder what is the reason of duplicate entries in ltp-aiodio.part4? i.e.
dio_sparse,aiodio_append,dio_append,dio_truncate... To create bigger load?
To duplicate entries in ltp-aiodio.part4 doesn't make much sense and I perfectly agree with you. Once the aiodio testing suite is finished, we do need to change runtest file in order to have multiple scenarios with different files/buffers size with a different number of sub-processes.
Quoted 8 lines
IMHO it'd make sense to run at least one test on .all_filesystems to check more filesystems (
dio_appendseems to be quick), but I wouldn't done it when there are duplicate entries.Kind regards,
Petr
Signature · 2 lines
-- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 16 lines · Petr Vorel
tmpfs does not support it.
Signed-off-by Petr Vorel<[email protected]>--- testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++-- testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++ testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++ testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++-- testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++-- 5 files changed, 32 insertions(+), 6 deletions(-)testcases/kernel/io/ltp-aiodio/aiodio_append.c +0
-0
testcases/kernel/io/ltp-aiodio/aiodio_append.c static void setup(void) · line 136
Quoted 8 lines
testcases/kernel/io/ltp-aiodio/aiodio_append.c +3
-2@@ -131,8 +131,10 @@ static void setup(void)static void cleanup (void ) { - *run_child =0 ; -SAFE_MUNMAP (run_child,sizeof (int )); +if (run_child) { + *run_child =0 ; +SAFE_MUNMAP (run_child,sizeof (int ));
SAFE_MUNMAP should be called always, even if *run_child == 0 (which happens if run() completed successfully).
Quoted 85 lines
testcases/kernel/io/ltp-aiodio/aiodio_append.c +5
-0+ } }static void run (void )@@ -177,6 +179,10 @@ static struct tst_test test = { {"b:", &str_numaio, "Number of async IO blocks (default 16)"}, {} }, + .skip_filesystems = (const char *[]) { + "tmpfs", + NULL + }, }; #else TST_TEST_TCONF("test requires libaio and its development packages");testcases/kernel/io/ltp-aiodio/dio_append.c +4
-0@@ -93,4 +93,8 @@ static struct tst_test test = { {"c:", &str_appends, "Number of appends (default 1000)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };testcases/kernel/io/ltp-aiodio/dio_read.c +4
-0@@ -177,4 +177,8 @@ static struct tst_test test = { {"s:", &str_filesize, "File size (default 128M)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };testcases/kernel/io/ltp-aiodio/dio_sparse.c +8
-2@@ -83,8 +83,10 @@ static void setup(void)static void cleanup (void ) { - *run_child =0 ; -SAFE_MUNMAP (run_child,sizeof (int )); +if (run_child) { + *run_child =0 ; +SAFE_MUNMAP (run_child,sizeof (int )); + } }static void run (void )@@ -129,4 +131,8 @@ static struct tst_test test = { {"o:", &str_offset, "File offset (default 0)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };testcases/kernel/io/ltp-aiodio/dio_truncate.c +4
-2@@ -107,8 +107,10 @@ static void setup(void)static void cleanup (void ) { - *run_child =0 ; -SAFE_MUNMAP (run_child,sizeof (int )); +if (run_child) { + *run_child =0 ; +SAFE_MUNMAP (run_child,sizeof (int )); + } }static void run (void )
testcases/kernel/io/ltp-aiodio/dio_truncate.c static struct tst_test test = { · line 172
Quoted 8 lines
testcases/kernel/io/ltp-aiodio/dio_truncate.c +4
-0@@ -163,4 +165,8 @@ static struct tst_test test = { {"c:", &str_numwrites, "Number of append & truncate (default 100)"}, {} }, + .skip_filesystems = (const char *[]) { +"tmpfs" , +NULL + }, };
Kind regards,
Andrea
Signature · 2 lines
-- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 1 line
SAFE_MUNMAPshould be called always, even if*run_child== 0 (which happens ifrun()completed successfully).
This is actually if (run_child) not if (*run_child) and it fixes the case where the test is skipped even before the run_child has been mmaped.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 6 lines
Hi!
Quoted 1 line
SAFE_MUNMAPshould be called always, even if*run_child== 0 (which happens ifrun()completed successfully).This is actually if (
run_child) not if (*run_child) and it fixes the case where the test is skipped even before therun_childhas been mmaped.
Yes, that's needed for tmpfs.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Looks good to me, but since we are right before release I would be more happier if this gets more than one review before it gets pushed.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Quoted 3 lines
Hi!
Looks good to me, but since we are right before release I would be more happier if this gets more than one review before it gets pushed.
Definitely. Li, Andrea, Martin, could you please have a look?
Kind regards,
Petr
Quoted 1 line
Reviewed-by Cyril Hrubis <[email protected]>
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
It makes sense to avoid running tests using O_DIRECT on tmpfs, so patch looks good to me.
Quoted 9 lines · Petr Vorel
Quoted 3 lines
Hi!
Looks good to me, but since we are right before release I would be more happier if this gets more than one review before it gets pushed.Definitely. Li, Andrea, Martin, could you please have a look?
Kind regards,
PetrQuoted 1 line
Reviewed-by Cyril Hrubis <[email protected]>
Kind regards,
Andrea
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
Hi,
one tiny nit below, otherwise:
Quoted 1 line · Petr Vorel
tmpfs does not support it.
What's "it"? ^
Quoted 11 lines
Signed-off-by Petr Vorel <[email protected]>--- testcases/kernel/io/ltp-aiodio/aiodio_append.c | 10 ++++++++-- testcases/kernel/io/ltp-aiodio/dio_append.c | 4 ++++ testcases/kernel/io/ltp-aiodio/dio_read.c | 4 ++++ testcases/kernel/io/ltp-aiodio/dio_sparse.c | 10 ++++++++-- testcases/kernel/io/ltp-aiodio/dio_truncate.c | 10 ++++++++-- 5 files changed, 32 insertions(+), 6 deletions(-)testcases/kernel/io/ltp-aiodio/aiodio_append.c +0
-0
Signature · 10 lines
Martin Doucha [email protected] QA Engineer for Software Maintenance SUSE LINUX, s.r.o. CORSO IIa Krizikova 148/34 186 00 Prague 8 Czech Republic -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi!
Quoted 3 lines
Quoted 1 line
tmpfs does not support it.
What's "it"? ^
Should be replaced by O_DIRECT I guess.
Signature · 5 lines
Cyril Hrubis [email protected] -- Mailing list info: https://lists.linux.it/listinfo/ltp
Hi Martin,
Quoted 4 lines
Hi,
one tiny nit below, otherwise:Reviewed-by Martin Doucha <[email protected]>
Thanks!
Quoted 4 lines · Petr Vorel
Quoted 1 line
tmpfs does not support it.
What's "it"? ^
+1, I'll add O_DIRECT.
Kind regards,
Petr
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp