Skip to contentSkip to conversation

crypto/qat: fix QAT GEN4 AEAD job in raw data path

PATCH Applied Kai Ji 3 participants 3 messages Jan 21, 2022 – Feb 8, 2022 Crypto API

lore
Share & tools
lore

Kai Ji

author
#0 lore raw

PATCH 1/1 crypto/qat: fix QAT GEN4 AEAD job in raw data path

This patch fix the cipher params configuration in AEAD job if QAT GEN4 unified cipher slice(UCS) enabled.

Fixes 328d690d2f60 ("crypto/qat: update raw data path")
Cc [email protected]
Signed-off-by Kai Ji <[email protected]>
---
 drivers/crypto/qat/qat_sym_hw_dp.c | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
drivers/crypto/qat/qat_sym_hw_dp.c +14 -2
index 12825e448b..792ad2b213 100644
@@ -533,8 +533,20 @@ enqueue_one_aead_job(struct qat_sym_session *ctx,
 	/* CPM 1.7 uses single pass to treat AEAD as cipher operation */
 	if (ctx->is_single_pass) {
 		enqueue_one_cipher_job(ctx, req, iv, ofs, data_len);
-		cipher_param->spc_aad_addr = aad->iova;
-		cipher_param->spc_auth_res_addr = digest->iova;
+
+		if (ctx->is_ucs) {
+			/* QAT GEN4 uses single pass to treat AEAD as cipher
+			 * operation
+			 */
+			struct icp_qat_fw_la_cipher_20_req_params *cipher_param_20 =
+				(void *)&req->serv_specif_rqpars;
+			cipher_param_20->spc_aad_addr = aad->iova;
+			cipher_param_20->spc_auth_res_addr = digest->iova;
+		} else {
+			cipher_param->spc_aad_addr = aad->iova;
+			cipher_param->spc_auth_res_addr = digest->iova;
+		}
+
 		return;
 	}
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Ji, Kai <[email protected]>
Sent: Friday, January 21, 2022 10:39 AM
To: [email protected]
Cc: [email protected]; Ji, Kai <[email protected]>; Zhang, Roy Fan <[email protected]>
Subject: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path

Quoted 8 lines

This patch fix the cipher params configuration in AEAD job if QAT GEN4 unified cipher slice(UCS) enabled.

Fixes 328d690d2f60 ("crypto/qat: update raw data path")
Cc [email protected]
Signed-off-by Kai Ji <[email protected]>

---

Nice catch, thanks!

Acked-by Fan Zhang <[email protected]>