Skip to contentSkip to conversation

arm: mvebu: Espressobin: Fix URLs in comments

PATCH In review Pali Rohár 2 participants 3 messages Jan 21, 2022 – Jan 31, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: mvebu: Espressobin: Fix URLs in comments

Use versioned URLs for line numbers as branches are moving in the time and use master branch for mv-ddr-marvell where is up-to-date code.

---
 board/Marvell/mvebu_armada-37xx/board.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/Marvell/mvebu_armada-37xx/board.c +2 -2
index e0e7720e4a1a..adee444555cf 100644
@@ -59,11 +59,11 @@ DECLARE_GLOBAL_DATA_PTR;
  * Memory Controller Registers
  *
  * Assembled based on public information:
- * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/master/wtmi/main.c#L332-336
+ * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/v2020.11.26/wtmi/main.c#L332-336
  * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-18.12/drivers/mv_ddr_mc6.h#L309-L332
  *
  * And checked against the written register values for the various topologies:
- * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-atf-mainline/a3700/mv_ddr_tim.h
+ * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/master/a3700/mv_ddr_tim.h
  */
 #define A3700_CH0_MC_CTRL2_REG		MVEBU_REGISTER(0x002c4)
 #define A3700_MC_CTRL2_SDRAM_TYPE_MASK	0xf
Signature · 1 line
2.20.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Pali Rohár

Use versioned URLs for line numbers as branches are moving in the time and use master branch for mv-ddr-marvell where is up-to-date code.

Thanks,
Stefan

Quoted 13 lines
---
  board/Marvell/mvebu_armada-37xx/board.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
board/Marvell/mvebu_armada-37xx/board.c +0 -0
index e0e7720e4a1a..adee444555cf 100644
@@ -59,11 +59,11 @@ DECLARE_GLOBAL_DATA_PTR;
   * Memory Controller Registers
   *
   * Assembled based on public information:

board/Marvell/mvebu_armada-37xx/board.c DECLARE_GLOBAL_DATA_PTR; · line 69

Quoted 10 lines
board/Marvell/mvebu_armada-37xx/board.c +2 -2
- * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/master/wtmi/main.c#L332-336
+ * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/v2020.11.26/wtmi/main.c#L332-336
   * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-18.12/drivers/mv_ddr_mc6.h#L309-L332
   *
   * And checked against the written register values for the various topologies:
- * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-atf-mainline/a3700/mv_ddr_tim.h
+ * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/master/a3700/mv_ddr_tim.h
   */
  #define A3700_CH0_MC_CTRL2_REG		MVEBU_REGISTER(0x002c4)
  #define A3700_MC_CTRL2_SDRAM_TYPE_MASK	0xf

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]
#2 lore raw
In reply to Pali Rohár
Quoted 4 lines · Pali Rohár

Use versioned URLs for line numbers as branches are moving in the time and use master branch for mv-ddr-marvell where is up-to-date code.

Applied to u-boot-marvell/master

Thanks,
Stefan

Quoted 12 lines
---
  board/Marvell/mvebu_armada-37xx/board.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
board/Marvell/mvebu_armada-37xx/board.c +0 -0
index e0e7720e4a1a..adee444555cf 100644
@@ -59,11 +59,11 @@ DECLARE_GLOBAL_DATA_PTR;
   * Memory Controller Registers
   *
   * Assembled based on public information:

board/Marvell/mvebu_armada-37xx/board.c DECLARE_GLOBAL_DATA_PTR; · line 69

Quoted 10 lines
board/Marvell/mvebu_armada-37xx/board.c +2 -2
- * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/master/wtmi/main.c#L332-336
+ * https://gitlab.nic.cz/turris/mox-boot-builder/-/blob/v2020.11.26/wtmi/main.c#L332-336
   * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-18.12/drivers/mv_ddr_mc6.h#L309-L332
   *
   * And checked against the written register values for the various topologies:
- * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/mv_ddr-armada-atf-mainline/a3700/mv_ddr_tim.h
+ * https://github.com/MarvellEmbeddedProcessors/mv-ddr-marvell/blob/master/a3700/mv_ddr_tim.h
   */
  #define A3700_CH0_MC_CTRL2_REG		MVEBU_REGISTER(0x002c4)
  #define A3700_MC_CTRL2_SDRAM_TYPE_MASK	0xf

Viele Grüße,
Stefan Roese

Signature · 3 lines
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: [email protected]