KVM: PPC: Book3S HV: HFSCR[PREFIX] does not exist
Subsystems (2)
Nicholas Piggin
reviewerPATCH 1/1 KVM: PPC: Book3S HV: HFSCR[PREFIX] does not exist
This facility is controlled by FSCR only. Reserved bits should not be set in the HFSCR register (although it's likely harmless as this position would not be re-used, and the L0 is forgiving here too).
--- arch/powerpc/include/asm/reg.h | 1 - arch/powerpc/kvm/book3s_hv.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/include/asm/reg.h +0 -1
@@ -417,7 +417,6 @@#define FSCR_DSCR __MASK(FSCR_DSCR_LG)#define FSCR_INTR_CAUSE (ASM_CONST(0xFF) << 56)/* interrupt cause */ #define SPRN_HFSCR 0xbe/* HV=1 Facility Status & Control Register */ -#define HFSCR_PREFIX __MASK(FSCR_PREFIX_LG)#define HFSCR_MSGP __MASK(FSCR_MSGP_LG)#define HFSCR_TAR __MASK(FSCR_TAR_LG)#define HFSCR_EBB __MASK(FSCR_EBB_LG)
arch/powerpc/kvm/book3s_hv.c +1 -1
@@ -2830,7 +2830,7 @@ static int kvmppc_core_vcpu_create_hv(struct kvm_vcpu *vcpu)* to trap and then we emulate them. */ vcpu->arch.hfscr =HFSCR_TAR |HFSCR_EBB |HFSCR_PM |HFSCR_BHRB | -HFSCR_DSCR |HFSCR_VECVSX |HFSCR_FP |HFSCR_PREFIX ; +HFSCR_DSCR |HFSCR_VECVSX |HFSCR_FP ;if (cpu_has_feature (CPU_FTR_HVMODE )) { vcpu->arch.hfscr &=mfspr (SPRN_HFSCR );#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
Signature · 1 line
2.23.0
Quoted 5 lines · Nicholas Piggin
This facility is controlled by FSCR only. Reserved bits should not be set in the HFSCR register (although it's likely harmless as this position would not be re-used, and the L0 is forgiving here too).
Signed-off-by Nicholas Piggin <[email protected]>
Quoted 30 lines
--- arch/powerpc/include/asm/reg.h | 1 - arch/powerpc/kvm/book3s_hv.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)arch/powerpc/include/asm/reg.h +0
-1@@ -417,7 +417,6 @@#define FSCR_DSCR __MASK(FSCR_DSCR_LG)#define FSCR_INTR_CAUSE (ASM_CONST(0xFF) << 56)/* interrupt cause */ #define SPRN_HFSCR 0xbe/* HV=1 Facility Status & Control Register */ -#define HFSCR_PREFIX __MASK(FSCR_PREFIX_LG)#define HFSCR_MSGP __MASK(FSCR_MSGP_LG)#define HFSCR_TAR __MASK(FSCR_TAR_LG)#define HFSCR_EBB __MASK(FSCR_EBB_LG)arch/powerpc/kvm/book3s_hv.c +1
-1@@ -2830,7 +2830,7 @@ static int kvmppc_core_vcpu_create_hv(struct kvm_vcpu *vcpu)* to trap and then we emulate them. */ vcpu->arch.hfscr =HFSCR_TAR |HFSCR_EBB |HFSCR_PM |HFSCR_BHRB | -HFSCR_DSCR |HFSCR_VECVSX |HFSCR_FP |HFSCR_PREFIX ; +HFSCR_DSCR |HFSCR_VECVSX |HFSCR_FP ;if (cpu_has_feature (CPU_FTR_HVMODE )) { vcpu->arch.hfscr &=mfspr (SPRN_HFSCR );#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
Michael Ellerman
AppliedQuoted 5 lines · Nicholas Piggin
This facility is controlled by FSCR only. Reserved bits should not be set in the HFSCR register (although it's likely harmless as this position would not be re-used, and the L0 is forgiving here too).
Applied to powerpc/topic/ppc-kvm.
[1/1] KVM: PPC: Book3S HV: HFSCR[PREFIX] does not exist
https://git.kernel.org/powerpc/c/861604614a94a7aabc111e4a18aaf5d56d270e8a
cheers