Skip to contentSkip to conversation

configs/qemu_aarch64_virt_defconfig: don't hard code getty port

PATCH In review Peter Korsgaard 3 participants 7 messages Jan 22, 2022 – Jan 23, 2022

lore
Share & tools
lore
#2 lore raw

PATCH 3/3 configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16

In reply to Peter Korsgaard
---
 configs/qemu_aarch64_virt_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/qemu_aarch64_virt_defconfig +1 -1
index 0caf38112d..9fbf293311 100644
@@ -20,7 +20,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config"
 BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/3 configs/qemu_aarch64_virt_defconfig: linux.config: enable fb/input support

In reply to Peter Korsgaard

The Linux config already enabled drm-virtio for graphics output, but not the corresponding virtio-input / evdev drivers for input or the compatibility fb option.

Enable them so keyboard/mouse input works and /dev/fb0 is provided.

---
 board/qemu/aarch64-virt/linux.config | 3 +++
 1 file changed, 3 insertions(+)
board/qemu/aarch64-virt/linux.config +3 -0
index e3a4a92913..f9763b73b7 100644
@@ -47,6 +47,7 @@ CONFIG_DUMMY=y
 CONFIG_MACVLAN=y
 CONFIG_VIRTIO_NET=y
 CONFIG_NLMON=y
+CONFIG_INPUT_EVDEV=y
 CONFIG_SERIAL_AMBA_PL011=y
 CONFIG_SERIAL_AMBA_PL011_CONSOLE=y
 CONFIG_VIRTIO_CONSOLE=y
@@ -56,9 +57,11 @@ CONFIG_TCG_TPM=y
 CONFIG_TCG_TIS=y
 CONFIG_DRM=y
 CONFIG_DRM_VIRTIO_GPU=y
+CONFIG_FB=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_PL031=y
 CONFIG_VIRTIO_PCI=y
+CONFIG_VIRTIO_INPUT=y
 CONFIG_VIRTIO_MMIO=y
 CONFIG_VIRTIO_MMIO_CMDLINE_DEVICES=y
 CONFIG_MAILBOX=y
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#0 lore raw

PATCH 1/3 configs/qemu_aarch64_virt_defconfig: don't hard code getty port

The Linux defconfig both has VT and serial port support, so it makes more sense to run getty on /dev/console instead of hard coding the serial port.

---
 configs/qemu_aarch64_virt_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/qemu_aarch64_virt_defconfig +0 -1
index e6b72d8838..0caf38112d 100644
@@ -4,7 +4,6 @@ BR2_cortex_a53=y
 
 # System
 BR2_SYSTEM_DHCP="eth0"
-BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#6 lore raw

Peter, All,

On 2022-01-22 16:37 +0100, Peter Korsgaard spake thusly:

Quoted 4 lines

The Linux defconfig both has VT and serial port support, so it makes more sense to run getty on /dev/console instead of hard coding the serial port.

Series of 3 patches applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 23 lines
---
 configs/qemu_aarch64_virt_defconfig | 1 -
 1 file changed, 1 deletion(-)
configs/qemu_aarch64_virt_defconfig +0 -1
index e6b72d8838..0caf38112d 100644
@@ -4,7 +4,6 @@ BR2_cortex_a53=y
 
 # System
 BR2_SYSTEM_DHCP="eth0"
-BR2_TARGET_GENERIC_GETTY_PORT="ttyAMA0"
 
 # Filesystem
 BR2_TARGET_ROOTFS_EXT2=y
Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16

In reply to Peter Korsgaard

Hello Peter, All

Le 22/01/2022 à 16:37, Peter Korsgaard a écrit :

Quoted 10 lines
---
 configs/qemu_aarch64_virt_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
configs/qemu_aarch64_virt_defconfig +0 -0
index 0caf38112d..9fbf293311 100644

configs/qemu_aarch64_virt_defconfig BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y · line 23

Quoted 5 lines
configs/qemu_aarch64_virt_defconfig +1 -1
@@ -20,7 +20,7 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"

Why just only taking care of this defconfig ?
Most qemu defconfig are using the same kernel version (5.15). Usually we try to keep all of them in sync.

Since Qemu defconfigs are runtime tested each week in GitLab-CI maybe we can safely switch to BR2_LINUX_KERNEL_LATEST_VERSION instead ?
But we have to check qemu defconfigs using a local kernel patch, currently ppc-mpc8544ds and arm-versatile or keeping kernel custom version for them.

Also BR2_LINUX_KERNEL_LATEST_VERSION refer to the latest stable kernel version, not the latest lts version.

Thoughts?

Best regards,
Romain

configs/qemu_aarch64_virt_defconfig BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y · line 26

Quoted 4 lines
configs/qemu_aarch64_virt_defconfig +0 -0
 BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
 BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/qemu/aarch64-virt/linux.config"
 BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#4 lore raw

Re: [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16

Quoted 4 lines · Romain Naour

configs/qemu_aarch64_virt_defconfig BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y · line 23

Quoted 2 lines
configs/qemu_aarch64_virt_defconfig +1 -1
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"

Why just only taking care of this defconfig ?

Simply because I did some other changes to it (see the other patches in the series).

Quoted 2 lines

Most qemu defconfig are using the same kernel version (5.15). Usually we try to keep all of them in sync.

Ok.

Quoted 7 lines

Since Qemu defconfigs are runtime tested each week in GitLab-CI maybe we can safely switch to BR2_LINUX_KERNEL_LATEST_VERSION instead ?
But we have to check qemu defconfigs using a local kernel patch, currently ppc-mpc8544ds and arm-versatile or keeping kernel custom version for them.

Also BR2_LINUX_KERNEL_LATEST_VERSION refer to the latest stable kernel version, not the latest lts version.

That would mean that they are not really reproducible, so I don't really like it.

--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Re: [Buildroot] [PATCH 3/3] configs/qemu_aarch64_virt_defconfig: bump Linux kernel to 5.15.16

Hello Peter,

Le 23/01/2022 à 15:48, Peter Korsgaard a écrit :

Quoted 7 lines · Romain Naour
Quoted 5 lines

configs/qemu_aarch64_virt_defconfig BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_15=y · line 23

Quoted 3 lines
configs/qemu_aarch64_virt_defconfig +1 -1
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.15.16"

Why just only taking care of this defconfig ?

Quoted 7 lines

Simply because I did some other changes to it (see the other patches in the series).

Quoted 2 lines

Most qemu defconfig are using the same kernel version (5.15). Usually we try to keep all of them in sync.

Ok.

To test all qemu defconfig in gitlab you can push a branch named "kernel-5.15.16-defconfigs-qemu"

Where: "kernel-5.15.16" is a prefix, "-defconfigs-" trigger a pipeline for testing Buildroot defconfis and "qemu" is a pattern to match all defconfig named qemu*.

See:
https://gitlab.com/buildroot.org/buildroot/-/commit/65d2f04c012af492a9b9da04dfa3b3cbd20347f1

The kernel 5.15 is not as old, do we want to follow closely the latest kernel version for Qemu defconfigs? But it's annoying to modify each time the kernel version in several place.

Quoted 10 lines
Quoted 8 lines

Since Qemu defconfigs are runtime tested each week in GitLab-CI maybe we can safely switch to BR2_LINUX_KERNEL_LATEST_VERSION instead ?
But we have to check qemu defconfigs using a local kernel patch, currently ppc-mpc8544ds and arm-versatile or keeping kernel custom version for them.

Also BR2_LINUX_KERNEL_LATEST_VERSION refer to the latest stable kernel version, not the latest lts version.

That would mean that they are not really reproducible, so I don't really like it.

For a given Buildroot version BR2_LINUX_KERNEL_LATEST_VERSION is set with a default kernel version.

Actually defconfigs are already not reproducible since the internal toolchain components version use the default version.
But indeed, the kernel version change faster than the toolchain.

Best regards,
Romain

Quoted 3 lines
Signature · 2 lines
-- 
Bye, Peter Korsgaard

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot