Skip to contentSkip to conversation

exit: export make_task_dead()

PATCH In review Randy Dunlap 2 participants 3 messages Jan 22, 2022 – Jan 24, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 exit: export make_task_dead()

In a config file from "kernel test robot <[email protected]>" for a different problem, this linker error was exposed when CONFIG_IA64_MCA_RECOVERY=m.

We could either export make_task_dead() or restrict IA64_MCA_RECOVERY to a bool Kconfig symbol instead of a tristate symbol, so go with the EXPORT_SYMBOL() path.

Fixes this build error:

ERROR: modpost: "make_task_dead" [arch/ia64/kernel/mca_recovery.ko] undefined!

Fixes 0e25498f8cd4 ("exit: Add and use make_task_dead.")
Cc "Eric W. Biederman" <[email protected]>
Cc Tony Luck <[email protected]>
Cc kernel test robot <[email protected]>
---
 kernel/exit.c |    1 +
 1 file changed, 1 insertion(+)
kernel/exit.c +1 -0
@@ -896,6 +896,7 @@ void __noreturn make_task_dead(int signr
 
 	do_exit(signr);
 }
+EXPORT_SYMBOL(make_task_dead);
 
 SYSCALL_DEFINE1(exit, int, error_code)
 {
#1 lore raw
Quoted 25 lines · Randy Dunlap

In a config file from "kernel test robot <[email protected]>" for a different problem, this linker error was exposed when CONFIG_IA64_MCA_RECOVERY=m.

We could either export make_task_dead() or restrict IA64_MCA_RECOVERY to a bool Kconfig symbol instead of a tristate symbol, so go with the EXPORT_SYMBOL() path.

Fixes this build error:

ERROR: modpost: "make_task_dead" [arch/ia64/kernel/mca_recovery.ko] undefined!

Fixes 0e25498f8cd4 ("exit: Add and use make_task_dead.")
Cc "Eric W. Biederman" <[email protected]>
Cc Tony Luck <[email protected]>
Cc kernel test robot <[email protected]>
---
 kernel/exit.c |    1 +
 1 file changed, 1 insertion(+)

kernel/exit.c void __noreturn make_task_dead(int signr · line 899

Quoted 4 lines
kernel/exit.c +1 -0
@@ -896,6 +896,7 @@ void __noreturn make_task_dead(int signr
 
 	do_exit(signr);
 }
+EXPORT_SYMBOL(make_task_dead);

EXPORT_SYMBOL_GPL and restricted, please.

Or even better: force the mca recovery code to be built in.

#2 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 6 lines · Randy Dunlap

In a config file from "kernel test robot <[email protected]>" for a different problem, this linker error was exposed when CONFIG_IA64_MCA_RECOVERY=m.

We could either export make_task_dead() or restrict IA64_MCA_RECOVERY to a bool Kconfig symbol instead of a tristate symbol, so go with the

OK, I'll send a patch to do ^^^that^^^ instead.

Quoted 20 lines
Quoted 20 lines

EXPORT_SYMBOL() path.

Fixes this build error:

ERROR: modpost: "make_task_dead" [arch/ia64/kernel/mca_recovery.ko] undefined!

Fixes 0e25498f8cd4 ("exit: Add and use make_task_dead.")
Cc "Eric W. Biederman" <[email protected]>
Cc Tony Luck <[email protected]>
Cc kernel test robot <[email protected]>
---
 kernel/exit.c |    1 +
 1 file changed, 1 insertion(+)
kernel/exit.c +0 -0
@@ -896,6 +896,7 @@ void __noreturn make_task_dead(int signr
 
Quoted 7 lines

kernel/exit.c void __noreturn make_task_dead(int signr · line 899

Quoted 3 lines
kernel/exit.c +1 -0
 	do_exit(signr);
 }
+EXPORT_SYMBOL(make_task_dead);

EXPORT_SYMBOL_GPL and restricted, please.

Or even better: force the mca recovery code to be built in.

thanks.

Signature · 1 line
~Randy