x86,kvm/xen: Remove superfluous .fixup usage
Subsystems (3)
PATCH 1/1 x86,kvm/xen: Remove superfluous .fixup usage
Commit 14243b387137 ("KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery") adds superfluous .fixup usage after the whole .fixup section was removed in commit e5eefda5aa51 ("x86: Remove .fixup section").
--- arch/x86/kvm/xen.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)
arch/x86/kvm/xen.c +2 -8
@@ -316,10 +316,7 @@ int __kvm_xen_has_interrupt(struct kvm_vcpu *v)"\tnotq %0\n" "\t" LOCK_PREFIX "andq %0, %2\n" "2:\n" -"\t.section .fixup,\"ax\"\n" -"3:\tjmp\t2b\n" -"\t.previous\n" - _ASM_EXTABLE_UA(1b ,3b ) + _ASM_EXTABLE_UA(1b ,2b ) : "=r" (evtchn_pending_sel)," +m" (vi->evtchn_pending_sel), "+m" (v->arch.xen.evtchn_pending_sel)
@@ -335,10 +332,7 @@ int __kvm_xen_has_interrupt(struct kvm_vcpu *v)"\tnotl %0\n" "\t" LOCK_PREFIX "andl %0, %2\n" "2:\n" -"\t.section .fixup,\"ax\"\n" -"3:\tjmp\t2b\n" -"\t.previous\n" - _ASM_EXTABLE_UA(1b ,3b ) + _ASM_EXTABLE_UA(1b ,2b ) : "=r" (evtchn_pending_sel32)," +m" (vi->evtchn_pending_sel), "+m" (v->arch.xen.evtchn_pending_sel)
Quoted 32 lines · Peter Zijlstra
Commit
14243b387137("KVM: x86/xen: AddKVM_IRQ_ROUTING_XEN_EVTCHNand event channel delivery") adds superfluous .fixup usage after the whole .fixup section was removed in commite5eefda5aa51("x86: Remove .fixup section").Fixes 14243b387137 ("KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery")Reported-by Borislav Petkov <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>--- arch/x86/kvm/xen.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)arch/x86/kvm/xen.c +1
-4@@ -316,10 +316,7 @@ int __kvm_xen_has_interrupt(struct kvm_vcpu *v)"\tnotq %0\n" "\t" LOCK_PREFIX "andq %0, %2\n" "2:\n" -"\t.section .fixup,\"ax\"\n" -"3:\tjmp\t2b\n" -"\t.previous\n" - _ASM_EXTABLE_UA(1b ,3b ) + _ASM_EXTABLE_UA(1b ,2b ) : "=r" (evtchn_pending_sel)," +m" (vi->evtchn_pending_sel), "+m" (v->arch.xen.evtchn_pending_sel)@@ -335,10 +332,7 @@ int __kvm_xen_has_interrupt(struct kvm_vcpu *v)"\tnotl %0\n"
arch/x86/kvm/xen.c int __kvm_xen_has_interrupt(struct kvm_vcpu *v) · line 338
Quoted 10 lines
arch/x86/kvm/xen.c +1
-4"\t" LOCK_PREFIX "andl %0, %2\n" "2:\n" -"\t.section .fixup,\"ax\"\n" -"3:\tjmp\t2b\n" -"\t.previous\n" - _ASM_EXTABLE_UA(1b ,3b ) + _ASM_EXTABLE_UA(1b ,2b ) : "=r" (evtchn_pending_sel32)," +m" (vi->evtchn_pending_sel), "+m" (v->arch.xen.evtchn_pending_sel)
Queued, thanks.
Paolo
Quoted 8 lines · Peter Zijlstra
Commit
14243b387137("KVM: x86/xen: AddKVM_IRQ_ROUTING_XEN_EVTCHNand event channel delivery") adds superfluous .fixup usage after the whole .fixup section was removed in commite5eefda5aa51("x86: Remove .fixup section").Fixes 14243b387137 ("KVM: x86/xen: Add KVM_IRQ_ROUTING_XEN_EVTCHN and event channel delivery")Reported-by Borislav Petkov <[email protected]>Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Thanks.