Add BananaPi R2 Pro board
Subsystems (2)
v2 cover Add BananaPi R2 Pro board
From: Frank Wunderlich <[email protected]>
This Series adds RK3568 based Bananapi R2 Board.
changes in v2:
- rebase on 5.17-rc1
- dropped patch for fixing dtbs_check (sent separately)
- verified pins on gpio-header (con2) and changed pinctrl where needed
- changed led part
Frank Wunderlich (2):
dt-bindings: rockchip: Add BananaPi R2 Pro Board
arm64: dts: rockchip: Add Bananapi R2 Pro
.../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 461 ++++++++++++++++++ 3 files changed, 467 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
Signature · 1 line
2.25.1
PATCH v2 1/2 dt-bindings: rockchip: Add BananaPi R2 Pro Board
From: Frank Wunderlich <[email protected]>
Add Devicetree Binding for Bananapi R2 Pro Board based on rk3568 SoC
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -651,6 +651,11 @@ properties: - const: rockchip,rk3568-evb1-v10 - const: rockchip,rk3568 + - description: Rockchip RK3568 Banana Pi R2 Pro + items: + - const: rockchip,rk3568-bpi-r2pro + - const: rockchip,rk3568 + additionalProperties: true ...
Signature · 1 line
2.25.1
Aw: [PATCH v2 1/2] dt-bindings: rockchip: Add BananaPi R2 Pro Board
Hi
just want to send a friendly ping ;)
regards Frank
Quoted 37 lines
Gesendet: Sonntag, 23. Januar 2022 um 14:51 Uhr
Von: "Frank Wunderlich" <[email protected]>
An: [email protected]
Cc: "Frank Wunderlich" <[email protected]>, "Rob Herring" <[email protected]>, "Heiko Stuebner" <[email protected]>, "Peter Geis" <[email protected]>, "Johan Jonker" <[email protected]>, [email protected], [email protected], [email protected]
Betreff: [PATCH v2 1/2] dt-bindings: rockchip: Add BananaPi R2 Pro BoardFrom: Frank Wunderlich <[email protected]>
Add Devicetree Binding for Bananapi R2 Pro Board based on rk3568 SoC
Co-developed-by Peter Geis <[email protected]>Signed-off-by Peter Geis <[email protected]>Signed-off-by Frank Wunderlich <[email protected]>--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)Documentation/devicetree/bindings/arm/rockchip.yaml +5
-1@@ -651,6 +651,11 @@ properties: - const: rockchip,rk3568-evb1-v10 - const: rockchip,rk3568 + - description: Rockchip RK3568 Banana Pi R2 Pro + items: + - const: rockchip,rk3568-bpi-r2pro + - const: rockchip,rk3568 + additionalProperties: true --2.25.1
Re: [PATCH v2 1/2] dt-bindings: rockchip: Add BananaPi R2 Pro Board
In reply to Frank WunderlichQuoted 11 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
Add Devicetree Binding for Bananapi R2 Pro Board based on rk3568 SoC
Co-developed-by Peter Geis <[email protected]>Signed-off-by Peter Geis <[email protected]>Signed-off-by Frank Wunderlich <[email protected]>--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 2/2 arm64: dts: rockchip: Add Bananapi R2 Pro
In reply to Frank WunderlichFrom: Frank Wunderlich <[email protected]>
This patch adds Devicetree for Bananapi R2 Pro based on RK3568. Add uart/sd/emmc/i2c/rk809/tsadc nodes for basic function. Gmac0 is directly connected to wan-port so usable without additional driver.
On gmac1 there is a switch (rtl8367rb) connected which have not yet a driver in mainline.
Patch also prepares nodes for GPIO header.
---
changes in v2:
- drop alias for gmac1 - currently unused due to missing switch driver
- verified / changed pinctrl of pwm/spi/uart/i2c
- add sharing information for con2 functions
- always power on vccio1 iodomain (used for rtc)
- drop V00 from model
- change leds (change names, drop label, add pinctrl, use color+function)
- add fan
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-bpi-r2-pro.dts | 461 ++++++++++++++++++ 2 files changed, 462 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -58,3 +58,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +461 -0
461 lines not on this page · raw message
Signature · 1 line
2.25.1
Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 Pro
Quoted 21 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
This patch adds Devicetree for Bananapi R2 Pro based on RK3568. Add uart/sd/emmc/i2c/rk809/tsadc nodes for basic function. Gmac0 is directly connected to wan-port so usable without additional driver.
On gmac1 there is a switch (rtl8367rb) connected which have not yet a driver in mainline.Patch also prepares nodes for GPIO header.
Co-developed-by Peter Geis <[email protected]>Signed-off-by Peter Geis <[email protected]>Signed-off-by Frank Wunderlich <[email protected]>---
+&gmac0 {arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +5
-0+ assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>; + clock_in_out = "input"; + phy-handle = <&rgmii_phy0>; + phy-mode = "rgmii";
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts line 93
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +10
-0+ pinctrl-names = "default"; + pinctrl-0 = <&gmac0_miim + &gmac0_tx_bus2 + &gmac0_rx_bus2 + &gmac0_rgmii_clk + &gmac0_rgmii_bus>; + + snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + /* Reset time is 20ms, 100ms for rtl8211f */
Is this really a rtl8211f? I don't know and it could indeed be a rtl8211f, I'm just asking because the comment is copy pasted from the Quartz64 board.
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts line 326
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +7
-0+ snps,reset-delays-us = <0 20000 100000>; + +&mdio0 { + rgmii_phy0: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0x0>; + };
0 is the broadcast address. I'm not sure if it's a good idea to use it. There should be another address the phy listens on.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Aw: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 Pro
Hi
Quoted 34 lines
Gesendet: Montag, 24. Januar 2022 um 09:31 Uhr
Von: "Sascha Hauer" <[email protected]>
An: "Frank Wunderlich" <[email protected]>
Cc: [email protected], "Frank Wunderlich" <[email protected]>, "Rob Herring" <[email protected]>, "Heiko Stuebner" <[email protected]>, "Peter Geis" <[email protected]>, "Johan Jonker" <[email protected]>, [email protected], [email protected], [email protected]
Betreff: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 ProQuoted 27 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
This patch adds Devicetree for Bananapi R2 Pro based on RK3568. Add uart/sd/emmc/i2c/rk809/tsadc nodes for basic function. Gmac0 is directly connected to wan-port so usable without additional driver.
On gmac1 there is a switch (rtl8367rb) connected which have not yet a driver in mainline.Patch also prepares nodes for GPIO header.
Co-developed-by Peter Geis <[email protected]>Signed-off-by Peter Geis <[email protected]>Signed-off-by Frank Wunderlich <[email protected]>---
+&gmac0 {arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +11
-0+ assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>; + clock_in_out = "input"; + phy-handle = <&rgmii_phy0>; + phy-mode = "rgmii"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_miim + &gmac0_tx_bus2 + &gmac0_rx_bus2 + &gmac0_rgmii_clk + &gmac0_rgmii_bus>;
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts line 93
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +4
-0+ + snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + /* Reset time is 20ms, 100ms for rtl8211f */Is this really a rtl8211f? I don't know and it could indeed be a rtl8211f, I'm just asking because the comment is copy pasted from the Quartz64 board.
i know thats a RTL8211 phy, but i see no additional letter on the chip, based on shematics it's a RTL8211F-CG
Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts line 326
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +7
-0+ snps,reset-delays-us = <0 20000 100000>; + +&mdio0 { + rgmii_phy0: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0x0>; + };0 is the broadcast address. I'm not sure if it's a good idea to use it. There should be another address the phy listens on.
took this from the 3568-EVB (like the most parts, as the board is mostly the same), and in linux it's the same and working. The switch have also phy-id 0 on mdio bus #1, are you sure this is invalid?
regards Frank
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 Pro
Quoted 45 lines · Frank Wunderlich
Hi
Quoted 34 lines
Gesendet: Montag, 24. Januar 2022 um 09:31 Uhr
Von: "Sascha Hauer" <[email protected]>
An: "Frank Wunderlich" <[email protected]>
Cc: [email protected], "Frank Wunderlich" <[email protected]>, "Rob Herring" <[email protected]>, "Heiko Stuebner" <[email protected]>, "Peter Geis" <[email protected]>, "Johan Jonker" <[email protected]>, [email protected], [email protected], [email protected]
Betreff: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 ProQuoted 27 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
This patch adds Devicetree for Bananapi R2 Pro based on RK3568. Add uart/sd/emmc/i2c/rk809/tsadc nodes for basic function. Gmac0 is directly connected to wan-port so usable without additional driver.
On gmac1 there is a switch (rtl8367rb) connected which have not yet a driver in mainline.Patch also prepares nodes for GPIO header.
Co-developed-by Peter Geis <[email protected]>Signed-off-by Peter Geis <[email protected]>Signed-off-by Frank Wunderlich <[email protected]>---
+&gmac0 {arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +11
-0+ assigned-clocks = <&cru SCLK_GMAC0_RX_TX>, <&cru SCLK_GMAC0>; + assigned-clock-parents = <&cru SCLK_GMAC0_RGMII_SPEED>, <&cru CLK_MAC0_2TOP>; + clock_in_out = "input"; + phy-handle = <&rgmii_phy0>; + phy-mode = "rgmii"; + pinctrl-names = "default"; + pinctrl-0 = <&gmac0_miim + &gmac0_tx_bus2 + &gmac0_rx_bus2 + &gmac0_rgmii_clk + &gmac0_rgmii_bus>;Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts line 93
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +4
-0+ + snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; + snps,reset-active-low; + /* Reset time is 20ms, 100ms for rtl8211f */Is this really a rtl8211f? I don't know and it could indeed be a rtl8211f, I'm just asking because the comment is copy pasted from the Quartz64 board.
Quoted 2 lines
i know thats a RTL8211 phy, but i see no additional letter on the chip, based on shematics it's a RTL8211F-CG
Ok. I just wanted to make sure you checked that.
Quoted 12 lines
Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts line 326
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-bpi-r2-pro.dts new file +7
-0+ snps,reset-delays-us = <0 20000 100000>; + +&mdio0 { + rgmii_phy0: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0x0>; + };0 is the broadcast address. I'm not sure if it's a good idea to use it. There should be another address the phy listens on.
Quoted 3 lines
took this from the 3568-EVB (like the most parts, as the board is mostly the same), and in linux it's the same and working. The switch have also phy-id 0 on mdio bus #1, are you sure this is invalid?
It's not invalid, it's just the broadcast address to which other phys might answer as well. Anyway, as long as there's only a single phy on the bus it's probably okay.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Aw: Re: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Bananapi R2 Pro
Quoted 8 lines
Gesendet: Montag, 24. Januar 2022 um 12:03 Uhr
Von: "Sascha Hauer" <[email protected]>Quoted 3 lines · Frank Wunderlich
took this from the 3568-EVB (like the most parts, as the board is mostly the same), and in linux it's the same and working. The switch have also phy-id 0 on mdio bus #1, are you sure this is invalid?
just to clarify: in linux dts only the basics were taken from evb and changed if needed (like iodomain, regulators).
mixed this with the barebox submsission where i mainly used the evb dts.
should i add a note in head that some parts are taken from EVB and vendors dts? As this is my first new DTS, i want to be sure the legal notice is correct.
Quoted 3 lines
It's not invalid, it's just the broadcast address to which other phys might answer as well. Anyway, as long as there's only a single phy on the bus it's probably okay.
ok, on mdio0 there is the rtl8211 phy and on mdio1 there is the rtl8367rb switch, so only 1 device per bus. I was not aware that 0 is broadcast.
regards Frank
Quoted 9 lines · Frank Wunderlich
This Series adds RK3568 based Bananapi R2 Board.
changes in v2:
- rebase on 5.17-rc1
- dropped patch for fixingdtbs_check(sent separately)
- verified pins on gpio-header (con2) and changed pinctrl where needed
- changed led part[...]
Applied, thanks!
[1/2] dt-bindings: rockchip: Add BananaPi R2 Pro Board [2/2] arm64: dts: rockchip: Add Bananapi R2 Pro
Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>