gvisor: add some missing definitions to vmx.h
PATCH 1/1 gvisor: add some missing definitions to vmx.h
From: Michael Davidson <[email protected]>
gvisor needs definitions for some additional secondary exec controls.
Tested: builds
--- arch/x86/include/asm/vmx.h | 1 + 1 file changed, 1 insertion(+)
arch/x86/include/asm/vmx.h +1 -0
@@ -67,6 +67,7 @@#define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)#define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)#define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING) +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)#define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)#define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)#define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)
Signature · 1 line
2.35.0.rc0.227.g00780c9af4-goog
Paolo Bonzini
maintainerQuoted 7 lines · Ayush Ranjan
From: Michael Davidson <[email protected]>
gvisor needs definitions for some additional secondary exec controls.
Tested: builds
Signed-off-by Ayush Ranjan <[email protected]>Signed-off-by Michael Davidson <[email protected]>
Incorrect order of the Signed-off-by header (author goes first, submitter goes last).
Quoted 9 lines
--- arch/x86/include/asm/vmx.h | 1 + 1 file changed, 1 insertion(+)arch/x86/include/asm/vmx.h +0
-0
arch/x86/include/asm/vmx.h line 73
Quoted 7 lines
arch/x86/include/asm/vmx.h +1
-0@@ -67,6 +67,7 @@#define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)#define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)#define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING) +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)#define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)#define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)#define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)
I'm not sure why gvisor would care about an internal Linux header. gvisor should only use arch/x86/include/uapi headers.
Paolo
Sean Christopherson
maintainerQuoted 16 lines · Paolo Bonzini
Quoted 7 lines · Ayush Ranjan
From: Michael Davidson <[email protected]>
gvisor needs definitions for some additional secondary exec controls.
Tested: builds
Signed-off-by Ayush Ranjan <[email protected]>Signed-off-by Michael Davidson <[email protected]>Incorrect order of the Signed-off-by header (author goes first, submitter goes last).
Quoted 4 lines
--- arch/x86/include/asm/vmx.h | 1 + 1 file changed, 1 insertion(+)
Quoted 15 lines
arch/x86/include/asm/vmx.h line 73
Quoted 12 lines
arch/x86/include/asm/vmx.h +1
-0@@ -67,6 +67,7 @@#define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)#define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)#define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING) +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)#define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)#define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)#define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)I'm not sure why gvisor would care about an internal Linux header. gvisor should only use
arch/x86/include/uapiheaders.
It's Google-internal kernel crud, this patch should not be merged. Though with a bit of patience, an equivalent patch will come with TDX support. If we do merge something before TDX, I'd strongly prefer to take that "complete" version with a rewritten changelog.
Abandoning this patch in favor of the more complete series of work quoted above.
Quoted 40 lines · Sean Christopherson
Quoted 16 lines · Paolo Bonzini
Quoted 7 lines · Ayush Ranjan
From: Michael Davidson <[email protected]>
gvisor needs definitions for some additional secondary exec controls.
Tested: builds
Signed-off-by Ayush Ranjan <[email protected]>Signed-off-by Michael Davidson <[email protected]>Incorrect order of the Signed-off-by header (author goes first, submitter goes last).
Quoted 4 lines
--- arch/x86/include/asm/vmx.h | 1 + 1 file changed, 1 insertion(+)Quoted 15 lines
arch/x86/include/asm/vmx.h line 73
Quoted 12 lines
arch/x86/include/asm/vmx.h +1
-0@@ -67,6 +67,7 @@#define SECONDARY_EXEC_ENCLS_EXITING VMCS_CONTROL_BIT(ENCLS_EXITING)#define SECONDARY_EXEC_RDSEED_EXITING VMCS_CONTROL_BIT(RDSEED_EXITING)#define SECONDARY_EXEC_ENABLE_PML VMCS_CONTROL_BIT(PAGE_MOD_LOGGING) +#define SECONDARY_EXEC_EPT_VE VMCS_CONTROL_BIT(EPT_VIOLATION_VE)#define SECONDARY_EXEC_PT_CONCEAL_VMX VMCS_CONTROL_BIT(PT_CONCEAL_VMX)#define SECONDARY_EXEC_XSAVES VMCS_CONTROL_BIT(XSAVES)#define SECONDARY_EXEC_MODE_BASED_EPT_EXEC VMCS_CONTROL_BIT(MODE_BASED_EPT_EXEC)I'm not sure why gvisor would care about an internal Linux header. gvisor should only use
arch/x86/include/uapiheaders.It's Google-internal kernel crud, this patch should not be merged. Though with a bit of patience, an equivalent patch will come with TDX support. If we do merge something before TDX, I'd strongly prefer to take that "complete" version with a rewritten changelog.