ata: pata_pdc202xx_old: make make static read-only array pio_timing const
Subsystems (2)
PATCH 1/1 ata: pata_pdc202xx_old: make make static read-only array pio_timing const
The static array pio_timing is read-only so it make sense to make it const.
--- drivers/ata/pata_pdc202xx_old.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/pata_pdc202xx_old.c +1 -1
@@ -78,7 +78,7 @@ static void pdc202xx_configure_piomode(struct ata_port *ap, struct ata_device *a {struct pci_dev *pdev =to_pci_dev (ap->host->dev);int port =0x60 +8 * ap->port_no +4 * adev->devno; -static u16 pio_timing[5 ] = { +static const u16 pio_timing[5 ] = {0x0913 ,0x050C ,0x0308 ,0x0206 ,0x0104 };u8 r_ap, r_bp;
Signature · 1 line
2.33.1
Hello!
Too many verbs in the subject. :-)
Quoted 4 lines · Colin Ian King
The static array
pio_timingis read-only so it make sense to make it const.Signed-off-by Colin Ian King <[email protected]>
With that fixed:
[...]
MBR, Sergey
Quoted 3 lines · Sergey Shtylyov
Hello!
Too many verbs in the subject. :-)
Yep. I will fix that when applying. No need to resend !
Quoted 11 lines · Colin Ian King
Quoted 5 lines
The static array
pio_timingis read-only so it make sense to make it const.Signed-off-by Colin Ian King <[email protected]>With that fixed:
Reviewed-by Sergey Shtylyov <[email protected]>
Thanks for the review.
Quoted 4 lines
[...]
MBR, Sergey
Signature · 2 lines
Damien Le Moal Western Digital Research
Quoted 6 lines · Damien Le Moal
Quoted 3 lines · Sergey Shtylyov
Hello!
Too many verbs in the subject. :-)
Yep. I will fix that when applying. No need to resend !
Thanks for fixing this up. Much appreciated.
Quoted 21 lines
Quoted 12 lines · Colin Ian King
Quoted 5 lines
The static array
pio_timingis read-only so it make sense to make it const.Signed-off-by Colin Ian King <[email protected]>With that fixed:
Reviewed-by Sergey Shtylyov <[email protected]>Thanks for the review.
Quoted 4 lines
[...]
MBR, Sergey
Damien Le Moal
AppliedQuoted 4 lines · Colin Ian King
The static array
pio_timingis read-only so it make sense to make it const.Signed-off-by Colin Ian King <[email protected]>
Applied to for-5.18. Thanks !
Signature · 2 lines
Damien Le Moal Western Digital Research