Skip to contentSkip to conversation

x86/pvh: print dom0 memory map

PATCH Superseded Roger Pau Monne 2 participants 2 messages Jan 24, 2022

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86/pvh: print dom0 memory map

I find it useful for debugging certain issues to have the memory map dom0 is using, so print it when using dom0=verbose on the command line.

---
 xen/arch/x86/e820.c             | 2 +-
 xen/arch/x86/hvm/dom0_build.c   | 6 ++++++
 xen/arch/x86/include/asm/e820.h | 1 +
 3 files changed, 8 insertions(+), 1 deletion(-)
xen/arch/x86/e820.c +1 -1
index aa602773bb..82e9ac46a0 100644
@@ -88,7 +88,7 @@ static void __init add_memory_region(unsigned long long start,
     e820.nr_map++;
 }
 
-static void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)
+void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)
 {
     unsigned int i;
 
xen/arch/x86/hvm/dom0_build.c +6 -0
index 739bb8adb6..93ebe4f404 100644
@@ -1271,6 +1271,12 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image,
         return rc;
     }
 
+    if ( opt_dom0_verbose )
+    {
+        printk("Dom%u memory map:\n", d->domain_id);
+        print_e820_memory_map(d->arch.e820, d->arch.nr_e820);
+    }
+
     printk("WARNING: PVH is an experimental mode with limited functionality\n");
     return 0;
 }
xen/arch/x86/include/asm/e820.h +1 -0
index 9d8f1ba960..7fcfde3b66 100644
@@ -32,6 +32,7 @@ extern int e820_change_range_type(
 extern int e820_add_range(
     struct e820map *, uint64_t s, uint64_t e, uint32_t type);
 extern unsigned long init_e820(const char *, struct e820map *);
+extern void print_e820_memory_map(struct e820entry *map, unsigned int entries);
 extern struct e820map e820;
 extern struct e820map e820_raw;
 
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Roger Pau Monne

I find it useful for debugging certain issues to have the memory map dom0 is using, so print it when using dom0=verbose on the command line.

with one further request:

xen/arch/x86/e820.c static void __init add_memory_region(unsigned long long start, · line 91

Quoted 8 lines
xen/arch/x86/e820.c +1 -1
@@ -88,7 +88,7 @@ static void __init add_memory_region(unsigned long long start,
     e820.nr_map++;
 }
 
-static void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)
+void __init print_e820_memory_map(struct e820entry *map, unsigned int entries)

While making this accessible from the outside, could you please make "map" pointer-to-const?

Jan