Skip to contentSkip to conversation

dt-bindings: pinctrl: qcom,pmic-mpp: Document PM8226 compatible

PATCH Applied Rayyan Ansari 4 participants 8 messages Jan 24, 2022 – Feb 11, 2022

Subsystems (6)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 dt-bindings: pinctrl: qcom,pmic-mpp: Document PM8226 compatible

Document the Device Tree binding for PM8226 MPPs.

---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml +1 -0
index 35c846f59979..df79274d0ec3 100644
@@ -21,6 +21,7 @@ properties:
           - qcom,pm8019-mpp
           - qcom,pm8038-mpp
           - qcom,pm8058-mpp
+          - qcom,pm8226-mpp
           - qcom,pm8821-mpp
           - qcom,pm8841-mpp
           - qcom,pm8916-mpp
Signature · 1 line
2.34.1
#1 lore raw

PATCH 2/3 pinctrl: qcom: spmi-mpp: Add PM8226 compatible

The PM8226 provides 8 MPPs.
Add a compatible to support them.

---
 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +1 -0
index b80723928b7e..6937157f50b3 100644
@@ -961,6 +961,7 @@ static int pmic_mpp_remove(struct platform_device *pdev)
 
 static const struct of_device_id pmic_mpp_of_match[] = {
 	{ .compatible = "qcom,pm8019-mpp", .data = (void *) 6 },
+	{ .compatible = "qcom,pm8226-mpp", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8841-mpp", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8916-mpp", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8941-mpp", .data = (void *) 8 },
Signature · 1 line
2.34.1
Reviewed-by on v1 2/3
#2 lore raw

Re: [PATCH 2/3] pinctrl: qcom: spmi-mpp: Add PM8226 compatible

Quoted 4 lines · Rayyan Ansari

The PM8226 provides 8 MPPs.
Add a compatible to support them.

Quoted 19 lines
---
 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/qcom/pinctrl-spmi-mpp.c +1 -0
index b80723928b7e..6937157f50b3 100644
@@ -961,6 +961,7 @@ static int pmic_mpp_remove(struct platform_device *pdev)
 
 static const struct of_device_id pmic_mpp_of_match[] = {
 	{ .compatible = "qcom,pm8019-mpp", .data = (void *) 6 },
+	{ .compatible = "qcom,pm8226-mpp", .data = (void *) 8 },
 	{ .compatible = "qcom,pm8841-mpp", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8916-mpp", .data = (void *) 4 },
 	{ .compatible = "qcom,pm8941-mpp", .data = (void *) 8 },
Signature · 1 line
2.34.1
#3 lore raw

PATCH 3/3 ARM: dts: qcom: pm8226: Add node for the MPP

In reply to Rayyan Ansari

The PM8226 provides 8 Multi-Purpose Pins (or MPPs for short). Add a node to support them.

---
 arch/arm/boot/dts/qcom-pm8226.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/qcom-pm8226.dtsi +10 -0
index dddb5150dfd7..9db3ea28b321 100644
@@ -16,6 +16,16 @@ pwrkey@800 {
 			debounce = <15625>;
 			bias-pull-up;
 		};
+
+		pm8226_mpps: mpps@a000 {
+			compatible = "qcom,pm8226-mpp", "qcom,spmi-mpp";
+			reg = <0xa000>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			gpio-ranges = <&pm8226_mpps 0 0 8>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
 	};
 
 	pm8226_1: pm8226@1 {
Signature · 1 line
2.34.1
#4 lore raw

Re: (subset) [PATCH 3/3] ARM: dts: qcom: pm8226: Add node for the MPP

Quoted 4 lines · Rayyan Ansari

The PM8226 provides 8 Multi-Purpose Pins (or MPPs for short). Add a node to support them.

Applied, thanks!

[3/3] ARM: dts: qcom: pm8226: Add node for the MPP

      commit: 5fbd593756be9a0ee710b15e14d2797bfbca108f

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>
Reviewed-by on v1 1/3
#5 lore raw
In reply to Rayyan Ansari
Quoted 3 lines · Rayyan Ansari

Document the Device Tree binding for PM8226 MPPs.

Quoted 19 lines
---
 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.yaml +1 -0
index 35c846f59979..df79274d0ec3 100644
@@ -21,6 +21,7 @@ properties:
           - qcom,pm8019-mpp
           - qcom,pm8038-mpp
           - qcom,pm8058-mpp
+          - qcom,pm8226-mpp
           - qcom,pm8821-mpp
           - qcom,pm8841-mpp
           - qcom,pm8916-mpp
Signature · 1 line
2.34.1