Skip to contentSkip to conversation

generic/273: use _get_file_block_size

PATCH In review Darrick J. Wong 2 participants 2 messages Jan 24, 2022 – Jan 25, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/273: use _get_file_block_size

From: Darrick J. Wong <[email protected]>

This test calculates the amount of free space on a filesystem and uses the block size to spread the work of filling the free space among a bunch of threads. Unfortunately, the test /should/ be using the allocation unit size, not the fs block size, which is why this test fails on configurations such as XFS realtime with a 28k extent size.

---
NOTE: This patch seems to fix the "porter not complete" problems on 5.16, but not on 5.17-rc1. However, 5.17-rc1 is totally broken (~72% failure rate) so I don't think I can count that as a serious QA effort.

---
 tests/generic/273 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tests/generic/273 +2 -2
index b5458a77..f86dae9b 100755
@@ -87,8 +87,8 @@ _do_workload()
 {
 	_pids=""
 	_pid=1
-	block_size=$(_get_block_size $SCRATCH_MNT)
-	
+	block_size=$(_get_file_block_size $SCRATCH_MNT)
+
 	_threads_set
 	_file_create $block_size