Skip to contentSkip to conversation

virtio-gpio: offered -> negotiated

PATCH In review Michael S. Tsirkin 3 participants 3 messages Jan 25, 2022 – Apr 13, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-gpio: offered -> negotiated

virtqueues are only discovered after FEATURES_OK.
As such it makes no sense to talk about virtqueues being affected by features which are offered but not negotiated, and doing so will confuse the reader.

---

Viresh, others your thoughts on this? Looks like an obvious typo to me, and something that I think we can fix under the editorial changes rule.

 virtio-gpio.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virtio-gpio.tex +1 -1
index 55c553f..8e5c7f0 100644
@@ -15,7 +15,7 @@ \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues}
 \end{description}
 
 The \field{eventq} virtqueue is available only if the \field{VIRTIO_GPIO_F_IRQ}
-feature is offered by the device.
+feature has been negotiated.
 
 \subsection{Feature bits}\label{sec:Device Types / GPIO Device / Feature bits}
 
Signature · 6 lines
MST


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Acked-by on v1 1/1
#1 lore raw
Quoted 20 lines · Michael S. Tsirkin

virtqueues are only discovered after FEATURES_OK.
As such it makes no sense to talk about virtqueues being affected by features which are offered but not negotiated, and doing so will confuse the reader.

---

Viresh, others your thoughts on this? Looks like an obvious typo to me, and something that I think we can fix under the editorial changes rule.

 virtio-gpio.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virtio-gpio.tex +0 -0
index 55c553f..8e5c7f0 100644

virtio-gpio.tex \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues} · line 20

Quoted 7 lines
virtio-gpio.tex +1 -1
@@ -15,7 +15,7 @@ \subsection{Virtqueues}\label{sec:Device Types / GPIO Device / Virtqueues}
 \end{description}
 
 The \field{eventq} virtqueue is available only if the \field{VIRTIO_GPIO_F_IRQ}
-feature is offered by the device.
+feature has been negotiated.
 
 \subsection{Feature bits}\label{sec:Device Types / GPIO Device / Feature bits}

Sorry for the delay, was out of office.

Signature · 5 lines
viresh

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 6 lines · Michael S. Tsirkin

virtqueues are only discovered after FEATURES_OK.
As such it makes no sense to talk about virtqueues being affected by features which are offered but not negotiated, and doing so will confuse the reader.

Quoted 8 lines

---

Viresh, others your thoughts on this? Looks like an obvious typo to me, and something that I think we can fix under the editorial changes rule.

 virtio-gpio.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Pushed as editorial update.

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php