Skip to contentSkip to conversation

hwmon: (pmbus) modify PSU fan_target convert value to false

PATCH In review krishnar4 2 participants 2 messages Jan 25, 2022 Hardware monitoring

lore
Share & tools
lore

krishnar4

author
#0 lore raw

PATCH 1/1 hwmon: (pmbus) modify PSU fan_target convert value to false

Description: PSU can't use sysfs fan_target to control PSU fan duty.

---
 drivers/hwmon/pmbus/pmbus_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/pmbus_core.c +1 -1
index 776ee2237be2..a56c2e1c4079 100644
@@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
 
 	sensor = pmbus_add_sensor(data, "fan", "target", index, page,
 				  0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
-				  false, false, true);
+				  false, false, false);
 
 	if (!sensor)
 		return -ENOMEM;
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 2 lines · On 1/25/22 05:01, krishnar4 wrote:

Description: PSU can't use sysfs fan_target to control PSU fan duty.

This is neither a proper subject nor a proper description. "modify PSU fan_target convert value to false" means that the value reported from the attribute is used directly without conversion. The subject should reflect this. "Description:" should not be part of the description, and the description should describe the reason for the change (ie explain clearly what is wrong).
"PSU can't use sysfs fan_target to control PSU fan duty" doesn't explain anything and doesn't match the subject.

Quoted 1 line

"krishnar4" is not an acceptable name. This needs to be a real name.

Guenter

Quoted 17 lines
---
  drivers/hwmon/pmbus/pmbus_core.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/pmbus/pmbus_core.c +1 -1
index 776ee2237be2..a56c2e1c4079 100644
@@ -1889,7 +1889,7 @@ static int pmbus_add_fan_ctrl(struct i2c_client *client,
 
  	sensor = pmbus_add_sensor(data, "fan", "target", index, page,
  				  0xff, PMBUS_VIRT_FAN_TARGET_1 + id, PSC_FAN,
-				  false, false, true);
+				  false, false, false);
 
  	if (!sensor)
  		return -ENOMEM;