power: supply: cros_usbpd: Use struct_size() helper in kzalloc()
Subsystems (2)
PATCH 1/1 power: supply: cros_usbpd: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:drivers/power/supply/cros_usbpd-charger.c:107:23: warning: using sizeof on a flexible structure
--- drivers/power/supply/cros_usbpd-charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/cros_usbpd-charger.c +1 -1
@@ -104,7 +104,7 @@ static int cros_usbpd_charger_ec_command(struct charger_data *charger,struct cros_ec_command *msg;int ret; - msg =kzalloc (sizeof (*msg) +max (outsize, insize),GFP_KERNEL ); + msg =kzalloc (struct_size (msg, data,max (outsize, insize)),GFP_KERNEL );if (!msg)return -ENOMEM ;
Signature · 1 line
2.27.0