perf/x86/rapl: replace 0 with NULL to initialize pointers
Subsystems (3)
PATCH 1/1 perf/x86/rapl: replace 0 with NULL to initialize pointers
Pointers should be initialized with NULL rather than zero. Fix these. Cleans up sparse warning:
arch/x86/events/rapl.c:540:59: warning: Using plain integer as NULL pointer
--- arch/x86/events/rapl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
arch/x86/events/rapl.c +4 -4
@@ -537,11 +537,11 @@ static struct perf_msr intel_rapl_spr_msrs[] = {* - want to use same event codes across both architectures */ static struct perf_msr amd_rapl_msrs[] = { - [PERF_RAPL_PP0 ] = {0 , &rapl_events_cores_group,0 , false,0 }, + [PERF_RAPL_PP0 ] = {0 , &rapl_events_cores_group,NULL , false,0 }, [PERF_RAPL_PKG ] = {MSR_AMD_PKG_ENERGY_STATUS , &rapl_events_pkg_group, test_msr, false,RAPL_MSR_MASK }, - [PERF_RAPL_RAM ] = {0 , &rapl_events_ram_group,0 , false,0 }, - [PERF_RAPL_PP1 ] = {0 , &rapl_events_gpu_group,0 , false,0 }, - [PERF_RAPL_PSYS ] = {0 , &rapl_events_psys_group,0 , false,0 }, + [PERF_RAPL_RAM ] = {0 , &rapl_events_ram_group,NULL , false,0 }, + [PERF_RAPL_PP1 ] = {0 , &rapl_events_gpu_group,NULL , false,0 }, + [PERF_RAPL_PSYS ] = {0 , &rapl_events_psys_group,NULL , false,0 }, };static int rapl_cpu_offline (unsigned int cpu)
Signature · 1 line
2.33.1
Quoted 4 lines · Colin Ian King
Pointers should be initialized with NULL rather than zero. Fix these. Cleans up sparse warning:
arch/x86/events/rapl.c:540:59: warning: Using plain integer as NULL pointer
also was
Quoted 26 lines
Signed-off-by Colin Ian King <[email protected]>--- arch/x86/events/rapl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)arch/x86/events/rapl.c +4
-4@@ -537,11 +537,11 @@ static struct perf_msr intel_rapl_spr_msrs[] = {* - want to use same event codes across both architectures */ static struct perf_msr amd_rapl_msrs[] = { - [PERF_RAPL_PP0 ] = {0 , &rapl_events_cores_group,0 , false,0 }, + [PERF_RAPL_PP0 ] = {0 , &rapl_events_cores_group,NULL , false,0 }, [PERF_RAPL_PKG ] = {MSR_AMD_PKG_ENERGY_STATUS , &rapl_events_pkg_group, test_msr, false,RAPL_MSR_MASK }, - [PERF_RAPL_RAM ] = {0 , &rapl_events_ram_group,0 , false,0 }, - [PERF_RAPL_PP1 ] = {0 , &rapl_events_gpu_group,0 , false,0 }, - [PERF_RAPL_PSYS ] = {0 , &rapl_events_psys_group,0 , false,0 }, + [PERF_RAPL_RAM ] = {0 , &rapl_events_ram_group,NULL , false,0 }, + [PERF_RAPL_PP1 ] = {0 , &rapl_events_gpu_group,NULL , false,0 }, + [PERF_RAPL_PSYS ] = {0 , &rapl_events_psys_group,NULL , false,0 }, };static int rapl_cpu_offline (unsigned int cpu)
Signature · 1 line
~Randy
Peter Zijlstra
maintainerQuoted 1 line · Colin Ian King
Pointers should be initialized with NULL rather than zero. Fix these.
Why ? This isn't C++, heck, this isn't even C, this is the kernel, we hard rely on NULL being 0.
Quoted 5 lines · Peter Zijlstra
Quoted 1 line · Colin Ian King
Pointers should be initialized with NULL rather than zero. Fix these.
Why ? This isn't C++, heck, this isn't even C, this is the kernel, we hard rely on NULL being 0.
It's a Sparse warning.
https://www.spinics.net/lists/linux-sparse/msg10066.html
regards,
dan carpenter