HID: google: Use struct_size() helper in kzalloc()
PATCH 1/1 HID: google: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:drivers/hid/hid-google-hammer.c:61:23: warning: using sizeof on a flexible structure
--- drivers/hid/hid-google-hammer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hid/hid-google-hammer.c +1 -1
@@ -58,7 +58,7 @@ static int cbas_ec_query_base(struct cros_ec_device *ec_dev, bool get_state,struct cros_ec_command *msg;int ret; - msg =kzalloc (sizeof (*msg) +max (sizeof (u32),sizeof (*params)), + msg =kzalloc (struct_size (msg, data,max (sizeof (u32),sizeof (*params))),GFP_KERNEL );if (!msg)return -ENOMEM ;
Signature · 1 line
2.27.0
Quoted 9 lines · Gustavo A. R. Silva
Make use of the
struct_size()helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.Also, address the following sparse warnings:
drivers/hid/hid-google-hammer.c:61:23: warning: using sizeof on a flexible structure
Applied, thank you Gustavo.
Signature · 2 lines
Jiri Kosina SUSE Labs