Skip to contentSkip to conversation

Remove 'at_console' and add 'netdev' D-Bus policy setting

PATCH In review Diederik de Haas 2 participants 4 messages Jan 26, 2022

lore
Share & tools
lore

Diederik de Haas

author
#0 lore raw

PATCH 1/1 Remove 'at_console' and add 'netdev' D-Bus policy setting

The 'at_console' D-Bus policy setting has been deprecated for more then 10 years and could be ignored at any time in the future. Moreover, while the intend was to allow locally logged on users to interact with iwd, it didn't actually do that. https://www.spinics.net/lists/linux-bluetooth/msg75267.html
and https://gitlab.freedesktop.org/dbus/dbus/-/issues/52 contain more details. Therefor remove the 'at_console_ setting block.

On Debian (based) systems, there is a standard defined group which is allowed to manage network interfaces, and that is the 'netdev' group. So add a D-Bus setting block to grant the 'netdev' group that access.

---
 src/iwd-dbus.conf | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/iwd-dbus.conf +1 -1
index 6b07ba9e..257b0b14 100644
@@ -18,7 +18,7 @@
     <allow send_interface="net.connman.iwd.Agent"/>
   </policy>
 
-  <policy at_console="true">
+  <policy group="netdev">
     <allow send_destination="net.connman.iwd"/>
     <allow send_interface="net.connman.iwd.Agent"/>
   </policy>
Signature · 1 line
2.34.1
author
#1 lore raw
Quoted 1 line · On Wednesday, 26 January 2022 15:04:23 CET Diederik de Haas wrote:

Therefor remove the 'at_console_ setting block.

Grr, the last underscore should've been a single quote.

author
#2 lore raw
Quoted 4 lines · On Wednesday, 26 January 2022 15:12:38 CET Diederik de Haas wrote:
Quoted 1 line · On Wednesday, 26 January 2022 15:04:23 CET Diederik de Haas wrote:

Therefor remove the 'at_console_ setting block.

Grr, the last underscore should've been a single quote.

And the title/subject is also suboptimal, maybe this?
dbus: Remove 'at_console' and add 'netdev' policy settings

Should I submit a v2 patch for that or can/will that be corrected when committing the patch?

Cheers,
Diederik

#3 lore raw

Hi Diederik,

Quoted 11 lines · Diederik de Haas
Quoted 4 lines · On Wednesday, 26 January 2022 15:12:38 CET Diederik de Haas wrote:
Quoted 1 line · On Wednesday, 26 January 2022 15:04:23 CET Diederik de Haas wrote:

Therefor remove the 'at_console_ setting block.

Grr, the last underscore should've been a single quote.

And the title/subject is also suboptimal, maybe this?
dbus: Remove 'at_console' and add 'netdev' policy settings

Should I submit a v2 patch for that or can/will that be corrected when committing the patch?

I haven't looked yet, so feel free to just submit a v2.

Regards,
-Denis