selftests/bpf: fix a clang compilation error
Subsystems (3)
PATCH 1/1 selftests/bpf: fix a clang compilation error
Compiling kernel and selftests/bpf with latest llvm like blow:
make -j LLVM=1
make -C tools/testing/selftests/bpf -j LLVM=1
I hit the following compilation error:
/.../prog_tests/log_buf.c:215:6: error: variable 'log_buf' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]
if (!ASSERT_OK_PTR(raw_btf_data, "raw_btf_data_good"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../prog_tests/log_buf.c:264:7: note: uninitialized use occurs here
free(log_buf);
^~~~~~~
/.../prog_tests/log_buf.c:215:2: note: remove the 'if' if its condition is always false
if (!ASSERT_OK_PTR(raw_btf_data, "raw_btf_data_good"))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/.../prog_tests/log_buf.c:205:15: note: initialize the variable 'log_buf' to silence this warning
char *log_buf;
^
= NULL1 error generated.
Compiler rightfully detected that log_buf is uninitialized in one of failure path as indicated in the above.
Proper initialization of 'log_buf' variable fixed the issue.
--- tools/testing/selftests/bpf/prog_tests/log_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/prog_tests/log_buf.c +1 -1
@@ -202,7 +202,7 @@ static void bpf_btf_load_log_buf(void)const void *raw_btf_data;__u32 raw_btf_size;struct btf *btf; -char *log_buf; +char *log_buf =NULL ;int fd =-1 ; btf =btf__new_empty ();
Signature · 1 line
2.30.2
Quoted 18 lines · Yonghong Song
Compiling kernel and selftests/bpf with latest llvm like blow:
make -j LLVM=1
make -Ctools/testing/selftests/bpf-j LLVM=1
I hit the following compilation error:
/.../prog_tests/log_buf.c:215:6: error: variable 'log_buf' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized]if (!ASSERT_OK_PTR(raw_btf_data, "raw_btf_data_good")) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /.../prog_tests/log_buf.c:264:7: note: uninitialized use occurs here free(log_buf); ^~~~~~~ /.../prog_tests/log_buf.c:215:2: note: remove the 'if' if its condition is always false if (!ASSERT_OK_PTR(raw_btf_data, "raw_btf_data_good")) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /.../prog_tests/log_buf.c:205:15: note: initialize the variable 'log_buf' to silence this warning char *log_buf; ^ = NULL
Quoted 5 lines
1 error generated.
Compiler rightfully detected that
log_bufis uninitialized in one of failure path as indicated in the above.
Yep, strange that GCC didn't detect this. Applied to bpf-next, thanks!
Quoted 23 lines
Proper initialization of '
log_buf' variable fixed the issue.Signed-off-by Yonghong Song <[email protected]>--- tools/testing/selftests/bpf/prog_tests/log_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/bpf/prog_tests/log_buf.c +1
-2@@ -202,7 +202,7 @@ static void bpf_btf_load_log_buf(void)const void *raw_btf_data;__u32 raw_btf_size;struct btf *btf; -char *log_buf; +char *log_buf =NULL ;int fd =-1 ; btf =btf__new_empty (); --2.30.2