Skip to contentSkip to conversation

net:amd-xgbe: ensure to reset the tx_timer_active flag

PATCH Applied Raju Rangoju 3 participants 3 messages Jan 27, 2022 – Jan 28, 2022

Subsystems (3)
lore
Share & tools
lore

Raju Rangoju

author maintainer
#0 lore raw

PATCH 1/1 net:amd-xgbe: ensure to reset the tx_timer_active flag

Ensure to reset the tx_timer_active flag in xgbe_stop(), otherwise a port restart may result in tx timeout due to uncleared flag.

Fixes c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
---
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/amd/xgbe/xgbe-drv.c +2 -0
index 492ac383f16d..4949ba69c097 100644
@@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)
 		if (!channel->tx_ring)
 			break;
 
+		/* Deactivate the Tx timer */
 		del_timer_sync(&channel->tx_timer);
+		channel->tx_timer_active = 0;
 	}
 }
 
Signature · 1 line
2.25.1
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Raju Rangoju

Ensure to reset the tx_timer_active flag in xgbe_stop(), otherwise a port restart may result in tx timeout due to uncleared flag.

Fixes c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
Quoted 18 lines
---
  drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/net/ethernet/amd/xgbe/xgbe-drv.c +2 -0
index 492ac383f16d..4949ba69c097 100644
@@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)
  		if (!channel->tx_ring)
  			break;
 
+		/* Deactivate the Tx timer */
  		del_timer_sync(&channel->tx_timer);
+		channel->tx_timer_active = 0;
  	}
  }
 
#2 lore raw
In reply to Raju Rangoju
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 27 Jan 2022 11:32:22 +0530 you wrote:

Ensure to reset the tx_timer_active flag in xgbe_stop(), otherwise a port restart may result in tx timeout due to uncleared flag.

Fixes c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")

[...]

Here is the summary with links:
- [net] net:amd-xgbe: ensure to reset the tx_timer_active flag

    https://git.kernel.org/netdev/net/c/7674b7b559b6

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html