net:amd-xgbe: ensure to reset the tx_timer_active flag
Subsystems (3)
Raju Rangoju
maintainerPATCH 1/1 net:amd-xgbe: ensure to reset the tx_timer_active flag
Ensure to reset the tx_timer_active flag in xgbe_stop(), otherwise a port restart may result in tx timeout due to uncleared flag.
Fixes c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")
Co-developed-by Sudheesh Mavila <[email protected]>
Signed-off-by Sudheesh Mavila <[email protected]>
Signed-off-by Raju Rangoju <[email protected]>
--- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/amd/xgbe/xgbe-drv.c +2 -0
@@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)if (!channel->tx_ring)break ; +/* Deactivate the Tx timer */ del_timer_sync (&channel->tx_timer); + channel->tx_timer_active =0 ; } }
Signature · 1 line
2.25.1
Quoted 8 lines · Raju Rangoju
Ensure to reset the
tx_timer_activeflag inxgbe_stop(), otherwise a port restart may result in tx timeout due to uncleared flag.Fixes c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")Co-developed-by Sudheesh Mavila <[email protected]>Signed-off-by Sudheesh Mavila <[email protected]>Signed-off-by Raju Rangoju <[email protected]>
Acked-by Tom Lendacky <[email protected]>
Quoted 18 lines
--- drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/ethernet/amd/xgbe/xgbe-drv.c +2
-0@@ -721,7 +721,9 @@ static void xgbe_stop_timers(struct xgbe_prv_data *pdata)if (!channel->tx_ring)break ; +/* Deactivate the Tx timer */ del_timer_sync (&channel->tx_timer); + channel->tx_timer_active =0 ; } }
This patch was applied to netdev/net.git (master) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Thu, 27 Jan 2022 11:32:22 +0530 you wrote:
Ensure to reset the
tx_timer_activeflag inxgbe_stop(), otherwise a port restart may result in tx timeout due to uncleared flag.Fixes c635eaacbf77 ("amd-xgbe: Remove Tx coalescing")Co-developed-by Sudheesh Mavila <[email protected]>Signed-off-by Sudheesh Mavila <[email protected]>Signed-off-by Raju Rangoju <[email protected]>[...]
Here is the summary with links:
- [net] net:amd-xgbe: ensure to reset the tx_timer_active flag
https://git.kernel.org/netdev/net/c/7674b7b559b6
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html