scsi: sr: Improve the judgment statement
PATCH 1/1 scsi: sr: Improve the judgment statement
The previous code has a less-than-perfect usage of judgment syntax.
When the med->media_event_code value is equal to 2 or 3, the same value is returned, so it would be better to combine the implementation statements when the med->media_event_code value is equal to 2 or 3.
Moreover, when a variable is equal to multiple values, it is better to use a switch judgment statement.
mechanical switch on the Drive) to eject the specified slot or media.
Signed-off-by tangmeng <[email protected]>
--- drivers/scsi/sr.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/scsi/sr.c +8 -4
@@ -222,12 +222,16 @@ static unsigned int sr_get_events(struct scsi_device *sdev)if (eh->nea || eh->notification_class !=0x4 )return 0 ; -if (med->media_event_code ==1 ) +switch (med->media_event_code) { +case 1 :return DISK_EVENT_EJECT_REQUEST ; -else if (med->media_event_code ==2 ) -return DISK_EVENT_MEDIA_CHANGE ; -else if (med->media_event_code ==3 ) +case 2 : +case 3 :return DISK_EVENT_MEDIA_CHANGE ; +default : +break ; + } +return 0 ; }
Signature · 1 line
2.20.1