dt-bindings: gpio: convert faraday,ftgpio01 to yaml
Subsystems (2)
PATCH 1/1 dt-bindings: gpio: convert faraday,ftgpio01 to yaml
Converts gpio/faraday,ftgpio010.txt to yaml.
---
This commit will cause arch/arm/boot/dts/moxart-uc7112lx.dts to fail DT validation,
but the GPIO driver need an interrupt so the current moxart DT is incomplete and the error is appropriate.
.../bindings/gpio/faraday,ftgpio010.txt | 27 --------- .../bindings/gpio/faraday,ftgpio010.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/faraday,ftgpio010.txt create mode 100644 Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.txt deleted +0 -27
@@ -1,27 +0,0 @@ -Faraday Technology FTGPIO010 GPIO Controller - -Required properties: - -- compatible : Should be one of - "cortina,gemini-gpio", "faraday,ftgpio010" - "moxa,moxart-gpio", "faraday,ftgpio010" - "faraday,ftgpio010" -- reg : Should contain registers location and length -- interrupts : Should contain the interrupt line for the GPIO block -- gpio-controller : marks this as a GPIO controller -- #gpio-cells : Should be 2, see gpio/gpio.txt -- interrupt-controller : marks this as an interrupt controller -- #interrupt-cells : a standard two-cell interrupt flag, see - interrupt-controller/interrupts.txt - -Example: - -gpio@4d000000 { - compatible = "cortina,gemini-gpio", "faraday,ftgpio010"; - reg = <0x4d000000 0x100>; - interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; -};
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml new file +59 -0
59 lines not on this page · raw message
Signature · 1 line
2.34.1
Quoted 3 lines · Corentin Labbe
Converts
gpio/faraday,ftgpio010.txtto yaml.Signed-off-by Corentin Labbe <[email protected]>
(...)
Quoted 2 lines
This commit will cause
arch/arm/boot/dts/moxart-uc7112lx.dtsto fail DT validation,
but the GPIO driver need an interrupt so the current moxart DT is incomplete and the error is appropriate.
The Linux GPIO driver may need it but that does not mean it is necessary for all other operating systems. (Could be a Linux bug.)
But I think it should be there because the hardware does support it and I'm pretty sure that IRQ is available on the Moxart as well, so:
Yours,
Linus Walleij
Quoted 114 lines · Corentin Labbe
Converts
gpio/faraday,ftgpio010.txtto yaml.Signed-off-by Corentin Labbe <[email protected]>---
This commit will cause
arch/arm/boot/dts/moxart-uc7112lx.dtsto fail DT validation,
but the GPIO driver need an interrupt so the current moxart DT is incomplete and the error is appropriate..../bindings/gpio/faraday,ftgpio010.txt | 27 --------- .../bindings/gpio/faraday,ftgpio010.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/faraday,ftgpio010.txt create mode 100644 Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yamlDocumentation/devicetree/bindings/gpio/faraday,ftgpio010.txt deleted +0
-27@@ -1,27 +0,0 @@ -Faraday Technology FTGPIO010 GPIO Controller - -Required properties: - -- compatible : Should be one of - "cortina,gemini-gpio", "faraday,ftgpio010" - "moxa,moxart-gpio", "faraday,ftgpio010" - "faraday,ftgpio010" -- reg : Should contain registers location and length -- interrupts : Should contain the interrupt line for the GPIO block -- gpio-controller : marks this as a GPIO controller -- #gpio-cells : Should be 2, see gpio/gpio.txt -- interrupt-controller : marks this as an interrupt controller -- #interrupt-cells : a standard two-cell interrupt flag, see - interrupt-controller/interrupts.txt - -Example: - -gpio@4d000000 { - compatible = "cortina,gemini-gpio", "faraday,ftgpio010"; - reg = <0x4d000000 0x100>; - interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; -};Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml new file +59
-1@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/faraday,ftgpio010.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Faraday Technology FTGPIO010 GPIO Controller + +maintainers: + - Linus Walleij <[email protected]> + +properties: + compatible: + oneOf: + - items: + - const: "cortina,gemini-gpio" + - const: "faraday,ftgpio010" + - items: + - const: "moxa,moxart-gpio" + - const: "faraday,ftgpio010" + - const: "faraday,ftgpio010" + reg: + maxItems: 1 + resets: + maxItems: 1 + clocks: + maxItems: 1 + interrupts: + maxItems: 1 + description: Should contain the interrupt line for the GPIO block + gpio-controller: true + "#gpio-cells": + const: 2 + interrupt-controller: true + "#interrupt-cells": + const: 2 + +required: + - compatible + - reg + - interrupts + - "#gpio-cells" + - interrupt-controller + - "#interrupt-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + gpio@4d000000 { + compatible = "cortina,gemini-gpio", "faraday,ftgpio010"; + reg = <0x4d000000 0x100>; + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + }; --
Quoted 2 lines
2.34.1
Looks good to me but I'll wait for Rob's ack on that.
Bart
Quoted 64 lines · Corentin Labbe
Converts
gpio/faraday,ftgpio010.txtto yaml.Signed-off-by Corentin Labbe <[email protected]>---
This commit will cause
arch/arm/boot/dts/moxart-uc7112lx.dtsto fail DT validation,
but the GPIO driver need an interrupt so the current moxart DT is incomplete and the error is appropriate..../bindings/gpio/faraday,ftgpio010.txt | 27 --------- .../bindings/gpio/faraday,ftgpio010.yaml | 59 +++++++++++++++++++ 2 files changed, 59 insertions(+), 27 deletions(-) delete mode 100644 Documentation/devicetree/bindings/gpio/faraday,ftgpio010.txt create mode 100644 Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yamlDocumentation/devicetree/bindings/gpio/faraday,ftgpio010.txt deleted +0
-27@@ -1,27 +0,0 @@ -Faraday Technology FTGPIO010 GPIO Controller - -Required properties: - -- compatible : Should be one of - "cortina,gemini-gpio", "faraday,ftgpio010" - "moxa,moxart-gpio", "faraday,ftgpio010" - "faraday,ftgpio010" -- reg : Should contain registers location and length -- interrupts : Should contain the interrupt line for the GPIO block -- gpio-controller : marks this as a GPIO controller -- #gpio-cells : Should be 2, see gpio/gpio.txt -- interrupt-controller : marks this as an interrupt controller -- #interrupt-cells : a standard two-cell interrupt flag, see - interrupt-controller/interrupts.txt - -Example: - -gpio@4d000000 { - compatible = "cortina,gemini-gpio", "faraday,ftgpio010"; - reg = <0x4d000000 0x100>; - interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; - gpio-controller; - #gpio-cells = <2>; - interrupt-controller; - #interrupt-cells = <2>; -};Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml new file +11
-0@@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpio/faraday,ftgpio010.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Faraday Technology FTGPIO010 GPIO Controller + +maintainers: + - Linus Walleij <[email protected]> +
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml line 21
Quoted 10 lines
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml new file +10
-0+properties: + compatible: + oneOf: + - items: + - const: "cortina,gemini-gpio" + - const: "faraday,ftgpio010" + - items: + - const: "moxa,moxart-gpio" + - const: "faraday,ftgpio010" + - const: "faraday,ftgpio010"
Don't need quotes.
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml line 23
Quoted 2 lines
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml new file +2
-0+ reg: + maxItems: 1
blank line between DT properties
With those fixes,
Quoted 40 lines
Documentation/devicetree/bindings/gpio/faraday,ftgpio010.yaml new file +36
-0+ resets: + maxItems: 1 + clocks: + maxItems: 1 + interrupts: + maxItems: 1 + description: Should contain the interrupt line for the GPIO block + gpio-controller: true + "#gpio-cells": + const: 2 + interrupt-controller: true + "#interrupt-cells": + const: 2 + +required: + - compatible + - reg + - interrupts + - "#gpio-cells" + - interrupt-controller + - "#interrupt-cells" + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + gpio@4d000000 { + compatible = "cortina,gemini-gpio", "faraday,ftgpio010"; + reg = <0x4d000000 0x100>; + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + };Signature · 1 line
2.34.1