perf/ftrace: system_wide collection is not effective by default
PATCH v2 1/1 perf/ftrace: system_wide collection is not effective by default
The ftrace.target.system_wide must be set before invoking evlist__create_maps(), otherwise it has no effect.
Fixes 53be50282269 ("perf ftrace: Add 'latency' subcommand")
Signed-off-by Changbin Du <[email protected]>
---
v2: fix error handling.
--- tools/perf/builtin-ftrace.c | 45 ++++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 21 deletions(-)
tools/perf/builtin-ftrace.c +24 -21
@@ -1115,6 +1115,7 @@ enum perf_ftrace_subcommand {int cmd_ftrace (int argc,const char **argv) {int ret; +int (*cmd_func)(struct perf_ftrace *) =NULL ;struct perf_ftrace ftrace = { .tracer =DEFAULT_TRACER , .target = { .uid =UINT_MAX , },
@@ -1221,6 +1222,28 @@ int cmd_ftrace(int argc, const char **argv) goto out_delete_filters; } +switch (subcmd) { +case PERF_FTRACE_TRACE : +if (!argc &&target__none (&ftrace.target)) + ftrace.target.system_wide = true; + cmd_func = __cmd_ftrace; +break ; +case PERF_FTRACE_LATENCY : +if (list_empty (&ftrace.filters)) { +pr_err ("Should provide a function to measure\n" ); +parse_options_usage (ftrace_usage, options,"T" ,1 ); + ret = -EINVAL ; + goto out_delete_filters; + } + cmd_func = __cmd_latency; +break ; +case PERF_FTRACE_NONE : +default : +pr_err ("Invalid subcommand\n" ); + ret = -EINVAL ; + goto out_delete_filters; + } + ret =target__validate (&ftrace.target);if (ret) {char errbuf[512 ];
@@ -1248,27 +1271,7 @@ int cmd_ftrace(int argc, const char **argv) goto out_delete_evlist; } -switch (subcmd) { -case PERF_FTRACE_TRACE : -if (!argc &&target__none (&ftrace.target)) - ftrace.target.system_wide = true; - ret =__cmd_ftrace (&ftrace); -break ; -case PERF_FTRACE_LATENCY : -if (list_empty (&ftrace.filters)) { -pr_err ("Should provide a function to measure\n" ); -parse_options_usage (ftrace_usage, options,"T" ,1 ); - ret = -EINVAL ; - goto out_delete_evlist; - } - ret =__cmd_latency (&ftrace); -break ; -case PERF_FTRACE_NONE : -default : -pr_err ("Invalid subcommand\n" ); - ret = -EINVAL ; -break ; - } + ret =cmd_func (&ftrace); out_delete_evlist:evlist__delete (ftrace.evlist);
Signature · 1 line
2.32.0
Hello,
Quoted 6 lines · Changbin Du
The ftrace.target.system_wide must be set before invoking
evlist__create_maps(), otherwise it has no effect.Fixes 53be50282269 ("perf ftrace: Add 'latency' subcommand")Signed-off-by Changbin Du <[email protected]>
Acked-by Namhyung Kim <[email protected]>
Thanks,
Namhyung
Em Tue, Feb 01, 2022 at 08:47:49PM -0800, Namhyung Kim escreveu:
Quoted 11 lines
Hello,
Quoted 6 lines · Changbin Du
The ftrace.target.system_wide must be set before invoking
evlist__create_maps(), otherwise it has no effect.Fixes 53be50282269 ("perf ftrace: Add 'latency' subcommand")Signed-off-by Changbin Du <[email protected]>Acked-by Namhyung Kim <[email protected]>
Thanks, applied.
- Arnaldo