Skip to contentSkip to conversation

arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO domain for GPIOE_2

PATCH Applied Dongjin Kim 2 participants 3 messages Jan 27, 2022 – Feb 4, 2022

Subsystems (2)
Device tree bindings Arm/Amlogic Meson SoC support
lore
Share & tools
lore

Dongjin Kim

author
#0 lore raw

PATCH 1/1 arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO domain for GPIOE_2

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
Signed-off-by Dongjin Kim <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1
index 212c6aa5a3b8..5751c48620ed 100644
@@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 16 lines · Dongjin Kim

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")
Signed-off-by Dongjin Kim <[email protected]>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +0 -0
index 212c6aa5a3b8..5751c48620ed 100644

arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts vddio_c: regulator-vddio_c { · line 129

Quoted 8 lines
arch/arm64/boot/dts/amlogic/meson-sm1-bananapi-m5.dts +1 -1
@@ -123,7 +123,7 @@ vddio_c: regulator-vddio_c {
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <3300000>;
 
-		enable-gpio = <&gpio GPIOE_2 GPIO_ACTIVE_HIGH>;
+		enable-gpio = <&gpio_ao GPIOE_2 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 		regulator-always-on;
Reviewed-by Neil Armstrong <[email protected]>

Thanks !

Neil

Applied
#2 lore raw
In reply to Dongjin Kim

Hi,

Quoted 6 lines · Dongjin Kim

GPIOE_2 is in AO domain and "<&gpio GPIOE_2 ...>" changes the state of TF_PWR_EN of 'FC8731' on BPI-M5

Fixes 976e920183e4 ("arm64: dts: meson-sm1: add Banana PI BPI-M5 board dts")

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v5.17/fixes)

[1/1] arm64: dts: meson-sm1-bananapi-m5: fix wrong GPIO domain for GPIOE_2

      https://git.kernel.org/amlogic/c/a5be3e5d46f373fe1d2ee835c7ede31769c241cd
Signature · 1 line
Neil