Skip to contentSkip to conversation

knotty: improve the UI information

PATCH Superseded Trevor Woerner 2 participants 2 messages Jan 27, 2022

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 knotty: improve the UI information

During a build you might end up with bitbake telling you:

	Currently 30 running tasks (2757 of 2757/3476 of 6390)

Which, to me, is really confusing. The forward slash separator and the two numbers immediately on each side of which are likely to be interpreted as being one unit (i.e. 2757/3476) but they're not. Also nothing is labeled, leaving the user to wonder what these numbers are.

Add labels, spaces, etc. to help clarify the information bitbake is trying to convey. The resulting line would appear as:

	30 running tasks (setscene:2757/2757 tasks:3476/6390)

---
changes since v1:
- improve the commit message
- remove the redundant word "Currently" in order to help keep the total line length manageable for users of 80-column terminals

---
 lib/bb/ui/knotty.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
lib/bb/ui/knotty.py +3 -3
index 484545a6..c2a7d06e 100644
@@ -276,11 +276,11 @@ class TerminalFilter(object):
             print(content)
         else:
             if self.quiet:
-                content = "Running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+                content = "Running tasks (setscene:%s/%s tasks:%s/%s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
             elif not len(activetasks):
-                content = "No currently running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+                content = "No currently running tasks (setscene:%s/%s tasks:%s/%s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
             else:
-                content = "Currently %2s running tasks (%s of %s/%s of %s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+                content = "%2s running tasks (setscene:%s/%s  tasks:%s/%s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
             maxtask = self.helper.tasknumber_total
             if not self.main_progress or self.main_progress.maxval != maxtask:
                 widgets = [' ', progressbar.Percentage(), ' ', progressbar.Bar()]
Signature · 1 line
2.34.1.75.gabe6bb3905
#1 lore raw
Quoted 36 lines

-----Original Message-----
From: [email protected] <bitbake- [email protected]> On Behalf Of Trevor Woerner
Sent: den 27 januari 2022 21:23
To: [email protected]
Subject: [bitbake-devel] [PATCH v2] knotty: improve the UI information

During a build you might end up with bitbake telling you:

	Currently 30 running tasks (2757 of 2757/3476 of 6390)

Which, to me, is really confusing. The forward slash separator and the two numbers immediately on each side of which are likely to be interpreted as being one unit (i.e. 2757/3476) but they're not. Also nothing is labeled, leaving the user to wonder what these numbers are.

Add labels, spaces, etc. to help clarify the information bitbake is trying to convey. The resulting line would appear as:

	30 running tasks (setscene:2757/2757 tasks:3476/6390)

---
changes since v1:
- improve the commit message
- remove the redundant word "Currently" in order to help keep the total line length manageable for users of 80-column terminals

---
 lib/bb/ui/knotty.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
lib/bb/ui/knotty.py +0 -0
index 484545a6..c2a7d06e 100644

lib/bb/ui/knotty.py class TerminalFilter(object): · line 281

Quoted 8 lines
lib/bb/ui/knotty.py +2 -2
@@ -276,11 +276,11 @@ class TerminalFilter(object):
             print(content)
         else:
             if self.quiet:
-                content = "Running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+                content = "Running tasks (setscene:%s/%s tasks:%s/%s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
             elif not len(activetasks):
-                content = "No currently running tasks (%s of %s/%s of %s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+                content = "No currently running tasks (setscene:%s/%s tasks:%s/%s)" % (self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)

Remove "currently" to keep the formatting consistent.

lib/bb/ui/knotty.py class TerminalFilter(object): · line 283

Quoted 3 lines
lib/bb/ui/knotty.py +1 -1
             else:
-                content = "Currently %2s running tasks (%s of %s/%s of %s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)
+                content = "%2s running tasks (setscene:%s/%s  tasks:%s/%s)" % (len(activetasks), self.helper.setscene_current, self.helper.setscene_total, self.helper.tasknumber_current, self.helper.tasknumber_total)

Remove one of the two spaces between setscene:%s/%s and tasks:%s/%s to keep the formatting consistent.

Quoted 5 lines
lib/bb/ui/knotty.py +0 -1
             maxtask = self.helper.tasknumber_total
             if not self.main_progress or self.main_progress.maxval != maxtask:
                 widgets = [' ', progressbar.Percentage(), ' ', progressbar.Bar()]
--

2.34.1.75.gabe6bb3905

//Peter